Bug 190591 - Remove StorageProcess leftover
Summary: Remove StorageProcess leftover
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-15 10:35 PDT by Patrick Griffis
Modified: 2018-10-15 16:19 PDT (History)
5 users (show)

See Also:

Attachments
Patch (482 bytes, patch)
2018-10-15 10:35 PDT, Patrick Griffis 		no flags Details | Formatted Diff | Diff
Remove StorageProcess leftover (1.20 KB, patch)
2018-10-15 10:41 PDT, Patrick Griffis 		no flags Details | Formatted Diff | Diff
Remove StorageProcess leftovers (3.43 KB, patch)
2018-10-15 12:30 PDT, Patrick Griffis 		no flags Details | Formatted Diff | Diff
Remove StorageProcess leftovers (4.78 KB, patch)
2018-10-15 13:55 PDT, Patrick Griffis 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Griffis 2018-10-15 10:35:02 PDT 
Remove StorageProcess leftover
Comment 1 Patrick Griffis 2018-10-15 10:35:10 PDT 
Created attachment 352340 [details]
Patch
Comment 2 Patrick Griffis 2018-10-15 10:41:47 PDT 
Created attachment 352341 [details]
Remove StorageProcess leftover
Comment 3 Michael Catanzaro 2018-10-15 11:00:26 PDT 
Comment on attachment 352341 [details]
Remove StorageProcess leftover

Looks like Mac builds are failing... it's still used in ChildProcessMac.mm and ProcessLauncherMac.mm.
Comment 4 Patrick Griffis 2018-10-15 12:30:49 PDT 
Created attachment 352359 [details]
Remove StorageProcess leftovers
Comment 5 Michael Catanzaro 2018-10-15 13:12:19 PDT 
Comment on attachment 352359 [details]
Remove StorageProcess leftovers

Missing ChangeLog

Also not sure why, because you clearly removed the enum value, but mac-32bit is unhappy for some reason:

In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/unified-sources/UnifiedSource11-mm.mm:3:
/Volumes/Data/EWS/WebKit/Source/WebKit/Shared/mac/ChildProcessMac.mm:279:13: error: enumeration value 'Storage' not handled in switch [-Werror,-Wswitch]
    switch (processType) {
            ^
/Volumes/Data/EWS/WebKit/Source/WebKit/Shared/mac/ChildProcessMac.mm:279:13: note: add missing switch cases
    switch (processType) {
            ^
1 error generated.
Comment 6 Patrick Griffis 2018-10-15 13:55:07 PDT 
Created attachment 352372 [details]
Remove StorageProcess leftovers
Comment 7 Michael Catanzaro 2018-10-15 15:48:41 PDT 
Comment on attachment 352372 [details]
Remove StorageProcess leftovers

Goodbye WebKitStorageProcess
Comment 8 Michael Catanzaro 2018-10-15 15:49:10 PDT 
Comment on attachment 352372 [details]
Remove StorageProcess leftovers

Well technically this needs owner approval. Leaving cq+ for an owner.
Comment 9 WebKit Commit Bot 2018-10-15 16:19:00 PDT 
Comment on attachment 352372 [details]
Remove StorageProcess leftovers

Clearing flags on attachment: 352372

Committed r237154: <https://trac.webkit.org/changeset/237154>
Comment 10 WebKit Commit Bot 2018-10-15 16:19:01 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2018-10-15 16:19:21 PDT 
<rdar://problem/45288591>