Bug 190585 - Share some code to dirty z-order and normal flow lists when child layers are added or removed
Summary: Share some code to dirty z-order and normal flow lists when child layers are ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-15 09:11 PDT by Simon Fraser (smfr)
Modified: 2018-10-15 10:52 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.41 KB, patch)
2018-10-15 09:12 PDT, Simon Fraser (smfr) 		zalan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2018-10-15 09:11:02 PDT 
Share some code to dirty z-order and normal flow lists when child layers are added or removed
Comment 1 Simon Fraser (smfr) 2018-10-15 09:12:07 PDT 
Created attachment 352329 [details]
Patch
Comment 2 zalan 2018-10-15 09:26:39 PDT 
Comment on attachment 352329 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352329&action=review

> Source/WebCore/rendering/RenderLayer.cpp:454
> +    if (!child.isNormalFlowOnly() || child.firstChild()) {

child.isNormalFlowOnly is always false here.
Comment 3 Simon Fraser (smfr) 2018-10-15 10:51:22 PDT 
https://trac.webkit.org/changeset/237123/webkit
Comment 4 Radar WebKit Bug Importer 2018-10-15 10:52:39 PDT 
<rdar://problem/45276600>