Bug 190576 - [GStreamer] fast/mediastream/get-user-media-device-id.html failing
Summary: [GStreamer] fast/mediastream/get-user-media-device-id.html failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords:
: 192886 205930 206149 210843 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-10-15 05:24 PDT by Claudio Saavedra
Modified: 2020-04-30 01:12 PDT (History)
19 users (show)

See Also:

Attachments
Patch (48.19 KB, patch)
2020-04-29 10:25 PDT, Philippe Normand 		no flags Details | Formatted Diff | Diff
Patch (48.06 KB, patch)
2020-04-29 10:30 PDT, Philippe Normand 		calvaris: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Claudio Saavedra 2018-10-15 05:24:52 PDT 
Since https://trac.webkit.org/changeset/236877/webkit this test is failing in GTK and WPE. This is MediaStream related.
Comment 1 Philippe Normand 2020-04-29 10:25:05 PDT 
Created attachment 397976 [details]
Patch
Comment 2 Philippe Normand 2020-04-29 10:30:56 PDT 
Created attachment 397977 [details]
Patch
Comment 3 Philippe Normand 2020-04-29 10:33:14 PDT 
*** Bug 205930 has been marked as a duplicate of this bug. ***
Comment 4 Philippe Normand 2020-04-29 10:34:50 PDT 
*** Bug 210337 has been marked as a duplicate of this bug. ***
Comment 5 Philippe Normand 2020-04-29 10:35:48 PDT 
*** Bug 206149 has been marked as a duplicate of this bug. ***
Comment 6 Philippe Normand 2020-04-29 10:36:09 PDT 
*** Bug 192886 has been marked as a duplicate of this bug. ***
Comment 7 Philippe Normand 2020-04-29 10:36:29 PDT 
*** Bug 210843 has been marked as a duplicate of this bug. ***
Comment 8 Xabier Rodríguez Calvar 2020-04-29 23:20:05 PDT 
Comment on attachment 397977 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397977&action=review

> Source/WebCore/platform/mediastream/gstreamer/MockRealtimeAudioSourceGStreamer.cpp:102
> +        auto sample = adoptGRef(gst_sample_new(buffer, caps.get(), nullptr, nullptr));

Buffer seems to be leaking here as gst_sample_new takes it as [transfer none] and it is not adopted to a GRefPtr above.
Comment 9 Philippe Normand 2020-04-30 01:12:18 PDT 
Committed r260937: <https://trac.webkit.org/changeset/260937>
Comment 10 Philippe Normand 2020-04-30 01:12:52 PDT 
Comment on attachment 397977 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397977&action=review

>> Source/WebCore/platform/mediastream/gstreamer/MockRealtimeAudioSourceGStreamer.cpp:102
>> +        auto sample = adoptGRef(gst_sample_new(buffer, caps.get(), nullptr, nullptr));
> 
> Buffer seems to be leaking here as gst_sample_new takes it as [transfer none] and it is not adopted to a GRefPtr above.

Oops indeed. Thanks for the review!