Bug 190566 - [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor action when forward delete is pressed outside a text field
Summary: [iOS] Pressing forward delete key in text field does nothing and we should no...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: iPhone / iPad iOS 12
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar, PlatformOnly
: 191087 191088 (view as bug list)
Depends on:
Blocks: 190571
  Show dependency treegraph
 
Reported: 2018-10-14 15:29 PDT by Daniel Bates
Modified: 2018-11-09 09:06 PST (History)
2 users (show)

See Also:


Attachments
Patch and layout test (8.38 KB, patch)
2018-11-07 09:30 PST, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2018-10-14 15:29:38 PDT
Pressing the forward delete key in a text field does nothing on iOS. This is because in both Webkit Legacy and Modern WebKit we look expect the character string of the WebEvent for the forward delete key to be the character 0xF728. It isn’t. Once we fix that we should also ensure that we only perform a forward deletion when inside an editable field as it is not meaningful to perform a forward deletion when not focused in a text field.
Comment 1 Daniel Bates 2018-10-14 15:32:00 PDT
Here is where we expect 0xF728 for the forward delete key in Modern WebKit: <https://trac.webkit.org/browser/webkit/trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm?rev=237053#L3831>.
Comment 2 Radar WebKit Bug Importer 2018-10-14 21:54:17 PDT
<rdar://problem/45262367>
Comment 3 Daniel Bates 2018-11-06 13:57:07 PST
*** Bug 191088 has been marked as a duplicate of this bug. ***
Comment 4 Daniel Bates 2018-11-06 13:57:36 PST
You can observe the fact that forward delete does nothing by performing the following:

1. Visit <data:text/html,<textarea></textarea>>.
2. Focus the text area and type "ha".
3. Press the left arrow key.
4. Press the forward delete key.

Then the text area should have the contents "h". But it has the contents "ha"; => nothing happened.
Comment 5 Daniel Bates 2018-11-06 13:59:01 PST
*** Bug 191087 has been marked as a duplicate of this bug. ***
Comment 6 Daniel Bates 2018-11-07 09:30:10 PST
Created attachment 354100 [details]
Patch and layout test
Comment 7 Daniel Bates 2018-11-09 09:06:53 PST
Comment on attachment 354100 [details]
Patch and layout test

Clearing flags on attachment: 354100

Committed r238033: <https://trac.webkit.org/changeset/238033>
Comment 8 Daniel Bates 2018-11-09 09:06:55 PST
All reviewed patches have been landed.  Closing bug.