Bug 190560 – [Apple Pay] New shipping methods are ignored when updating after the shippingaddresschange event

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andy Estes]

[Apple Pay] New shipping methods are ignored when updating after the shippingaddresschange event

[Andy Estes]

rdar://problem/44559075

[Andy Estes]

Created attachment 352274 [details]
Patch

[youenn fablet]

Comment on attachment 352274 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352274&action=review

> Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:266
> +    }

I guess there is some existing code that extracts shipping methods from shipping options.
Would it be worth to share the code?

> Source/WebCore/testing/MockPaymentCoordinator.cpp:115
> +    return applePayShippingMethods;

Maybe WTF::map if you like it.

[Andy Estes]

Comment on attachment 352274 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352274&action=review

>> Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:266
>> +    }
> 
> I guess there is some existing code that extracts shipping methods from shipping options.
> Would it be worth to share the code?

Yup, good call.

>> Source/WebCore/testing/MockPaymentCoordinator.cpp:115
>> +    return applePayShippingMethods;
> 
> Maybe WTF::map if you like it.

Very nice.

[Andy Estes]

Created attachment 352363 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 352363 [details]
Patch

Clearing flags on attachment: 352363

Committed r237142: <https://trac.webkit.org/changeset/237142>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.