Bug 190558 - [Payment Request] PaymentResponse should be a ContextDestructionObserver
Summary: [Payment Request] PaymentResponse should be a ContextDestructionObserver
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-13 23:10 PDT by Andy Estes
Modified: 2018-10-15 12:38 PDT (History)
9 users (show)

See Also:


Attachments
Patch (5.17 KB, patch)
2018-10-13 23:14 PDT, Andy Estes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2018-10-13 23:10:53 PDT
[Payment Request] PaymentResponse should be a ContextDestructionObserver
Comment 1 Andy Estes 2018-10-13 23:14:45 PDT
Created attachment 352266 [details]
Patch
Comment 2 EWS Watchlist 2018-10-13 23:16:03 PDT
Attachment 352266 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/paymentrequest/PaymentResponse.cpp:39:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2018-10-15 12:37:26 PDT
Comment on attachment 352266 [details]
Patch

Clearing flags on attachment: 352266

Committed r237133: <https://trac.webkit.org/changeset/237133>
Comment 4 WebKit Commit Bot 2018-10-15 12:37:28 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-10-15 12:38:32 PDT
<rdar://problem/45280768>