Bug 190555 - [WHLSL] Migrated WebGPUShadingLanguageRI to the W3C
Summary: [WHLSL] Migrated WebGPUShadingLanguageRI to the W3C
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-13 13:38 PDT by Myles C. Maxfield
Modified: 2018-10-15 12:20 PDT (History)
8 users (show)

See Also:


Attachments
Patch (1.97 MB, patch)
2018-10-13 13:44 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2018-10-13 13:38:12 PDT
[WHLSL] Migrated WebGPUShadingLanguageRI to the W3C
Comment 1 Myles C. Maxfield 2018-10-13 13:44:03 PDT
Created attachment 352257 [details]
Patch
Comment 2 WebKit Commit Bot 2018-10-13 23:31:10 PDT
Comment on attachment 352257 [details]
Patch

Rejecting attachment 352257 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 352257, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 5000 characters of output:
geRI/Program.js
	D	Tools/WebGPUShadingLanguageRI/ProgramWithUnnecessaryThingsRemoved.js
	D	Tools/WebGPUShadingLanguageRI/PropertyAccessExpression.js
	D	Tools/WebGPUShadingLanguageRI/PropertyResolver.js
	D	Tools/WebGPUShadingLanguageRI/PtrType.js
	D	Tools/WebGPUShadingLanguageRI/ReadModifyWriteExpression.js
	D	Tools/WebGPUShadingLanguageRI/RecursionChecker.js
	D	Tools/WebGPUShadingLanguageRI/RecursiveTypeChecker.js
	D	Tools/WebGPUShadingLanguageRI/ReferenceType.js
	D	Tools/WebGPUShadingLanguageRI/ResolveNames.js
	D	Tools/WebGPUShadingLanguageRI/ResolveOverloadImpl.js
	D	Tools/WebGPUShadingLanguageRI/ResolveProperties.js
	D	Tools/WebGPUShadingLanguageRI/ResolveTypeDefs.js
	D	Tools/WebGPUShadingLanguageRI/ResourceSemantic.js
	D	Tools/WebGPUShadingLanguageRI/Return.js
	D	Tools/WebGPUShadingLanguageRI/ReturnChecker.js
	D	Tools/WebGPUShadingLanguageRI/ReturnException.js
	D	Tools/WebGPUShadingLanguageRI/Rewriter.js
	D	Tools/WebGPUShadingLanguageRI/SPIR-V.js
	D	Tools/WebGPUShadingLanguageRI/SPIRV.html
	D	Tools/WebGPUShadingLanguageRI/SPIRVCodegen.js
	D	Tools/WebGPUShadingLanguageRI/SPIRVTypeAnalyzer.js
	D	Tools/WebGPUShadingLanguageRI/SPIRVVariableAnalyzer.js
	D	Tools/WebGPUShadingLanguageRI/Sampler.js
	D	Tools/WebGPUShadingLanguageRI/Semantic.js
	D	Tools/WebGPUShadingLanguageRI/SpecializationConstantSemantic.js
	D	Tools/WebGPUShadingLanguageRI/StageInOutSemantic.js
	D	Tools/WebGPUShadingLanguageRI/StandardLibrary.js
	D	Tools/WebGPUShadingLanguageRI/StatementCloner.js
	D	Tools/WebGPUShadingLanguageRI/StructLayoutBuilder.js
	D	Tools/WebGPUShadingLanguageRI/StructType.js
	D	Tools/WebGPUShadingLanguageRI/SwitchCase.js
	D	Tools/WebGPUShadingLanguageRI/SwitchStatement.js
	D	Tools/WebGPUShadingLanguageRI/SynthesizeArrayOperatorLength.js
	D	Tools/WebGPUShadingLanguageRI/SynthesizeCopyConstructorOperator.js
	D	Tools/WebGPUShadingLanguageRI/SynthesizeDefaultConstructorOperator.js
	D	Tools/WebGPUShadingLanguageRI/SynthesizeEnumFunctions.js
	D	Tools/WebGPUShadingLanguageRI/SynthesizeStructAccessors.js
	D	Tools/WebGPUShadingLanguageRI/TernaryExpression.js
	D	Tools/WebGPUShadingLanguageRI/Test.html
	D	Tools/WebGPUShadingLanguageRI/Test.js
	D	Tools/WebGPUShadingLanguageRI/Texture.js
	D	Tools/WebGPUShadingLanguageRI/TextureOperations.js
	D	Tools/WebGPUShadingLanguageRI/TrapStatement.js
	D	Tools/WebGPUShadingLanguageRI/Type.js
	D	Tools/WebGPUShadingLanguageRI/TypeDef.js
	D	Tools/WebGPUShadingLanguageRI/TypeDefResolver.js
	D	Tools/WebGPUShadingLanguageRI/TypeOverloadResolutionFailure.js
	D	Tools/WebGPUShadingLanguageRI/TypeRef.js
	D	Tools/WebGPUShadingLanguageRI/TypedValue.js
	D	Tools/WebGPUShadingLanguageRI/UintLiteral.js
	D	Tools/WebGPUShadingLanguageRI/UintLiteralType.js
	D	Tools/WebGPUShadingLanguageRI/UnificationContext.js
	D	Tools/WebGPUShadingLanguageRI/UnreachableCodeChecker.js
	D	Tools/WebGPUShadingLanguageRI/Value.js
	D	Tools/WebGPUShadingLanguageRI/VariableDecl.js
	D	Tools/WebGPUShadingLanguageRI/VariableRef.js
	D	Tools/WebGPUShadingLanguageRI/VectorType.js
	D	Tools/WebGPUShadingLanguageRI/VisitingSet.js
	D	Tools/WebGPUShadingLanguageRI/Visitor.js
	D	Tools/WebGPUShadingLanguageRI/WLexicalError.js
	D	Tools/WebGPUShadingLanguageRI/WSyntaxError.js
	D	Tools/WebGPUShadingLanguageRI/WTrapError.js
	D	Tools/WebGPUShadingLanguageRI/WTypeError.js
	D	Tools/WebGPUShadingLanguageRI/WhileLoop.js
	D	Tools/WebGPUShadingLanguageRI/WrapChecker.js
	D	Tools/WebGPUShadingLanguageRI/index.html
	D	Tools/WebGPUShadingLanguageRI/spirv.core.grammar.json
	D	Tools/WebGPUShadingLanguageRI/wsl-tests.yaml
	M	Tools/ChangeLog
	D+	Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/AppIcon.appiconset/
	D+	Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Base.lproj/
	D+	Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/
	D+	Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/
	D+	Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/
	D+	Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/
	D+	Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/
	D+	Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/
	D+	Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/
	D+	Tools/WebGPUShadingLanguageRI/Metal/
	D+	Tools/WebGPUShadingLanguageRI/

ERROR from SVN:
A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output:
Commits are currently disabled while we update infrastructure.
W: 180c8c41a3d8dadcec578204e33934eebc985135 and refs/remotes/origin/master differ, using rebase:
:040000 040000 d8067588fee8b9358f1a4051d0219295c1ad32cf 9c8b0ceaa22b2c82d26c613ffc9416cb23f803a7 M	Tools
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: https://webkit-queues.webkit.org/results/9565361
Comment 3 WebKit Commit Bot 2018-10-14 22:03:38 PDT
Comment on attachment 352257 [details]
Patch

Rejecting attachment 352257 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 352257, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 5000 characters of output:
geRI/Program.js
	D	Tools/WebGPUShadingLanguageRI/ProgramWithUnnecessaryThingsRemoved.js
	D	Tools/WebGPUShadingLanguageRI/PropertyAccessExpression.js
	D	Tools/WebGPUShadingLanguageRI/PropertyResolver.js
	D	Tools/WebGPUShadingLanguageRI/PtrType.js
	D	Tools/WebGPUShadingLanguageRI/ReadModifyWriteExpression.js
	D	Tools/WebGPUShadingLanguageRI/RecursionChecker.js
	D	Tools/WebGPUShadingLanguageRI/RecursiveTypeChecker.js
	D	Tools/WebGPUShadingLanguageRI/ReferenceType.js
	D	Tools/WebGPUShadingLanguageRI/ResolveNames.js
	D	Tools/WebGPUShadingLanguageRI/ResolveOverloadImpl.js
	D	Tools/WebGPUShadingLanguageRI/ResolveProperties.js
	D	Tools/WebGPUShadingLanguageRI/ResolveTypeDefs.js
	D	Tools/WebGPUShadingLanguageRI/ResourceSemantic.js
	D	Tools/WebGPUShadingLanguageRI/Return.js
	D	Tools/WebGPUShadingLanguageRI/ReturnChecker.js
	D	Tools/WebGPUShadingLanguageRI/ReturnException.js
	D	Tools/WebGPUShadingLanguageRI/Rewriter.js
	D	Tools/WebGPUShadingLanguageRI/SPIR-V.js
	D	Tools/WebGPUShadingLanguageRI/SPIRV.html
	D	Tools/WebGPUShadingLanguageRI/SPIRVCodegen.js
	D	Tools/WebGPUShadingLanguageRI/SPIRVTypeAnalyzer.js
	D	Tools/WebGPUShadingLanguageRI/SPIRVVariableAnalyzer.js
	D	Tools/WebGPUShadingLanguageRI/Sampler.js
	D	Tools/WebGPUShadingLanguageRI/Semantic.js
	D	Tools/WebGPUShadingLanguageRI/SpecializationConstantSemantic.js
	D	Tools/WebGPUShadingLanguageRI/StageInOutSemantic.js
	D	Tools/WebGPUShadingLanguageRI/StandardLibrary.js
	D	Tools/WebGPUShadingLanguageRI/StatementCloner.js
	D	Tools/WebGPUShadingLanguageRI/StructLayoutBuilder.js
	D	Tools/WebGPUShadingLanguageRI/StructType.js
	D	Tools/WebGPUShadingLanguageRI/SwitchCase.js
	D	Tools/WebGPUShadingLanguageRI/SwitchStatement.js
	D	Tools/WebGPUShadingLanguageRI/SynthesizeArrayOperatorLength.js
	D	Tools/WebGPUShadingLanguageRI/SynthesizeCopyConstructorOperator.js
	D	Tools/WebGPUShadingLanguageRI/SynthesizeDefaultConstructorOperator.js
	D	Tools/WebGPUShadingLanguageRI/SynthesizeEnumFunctions.js
	D	Tools/WebGPUShadingLanguageRI/SynthesizeStructAccessors.js
	D	Tools/WebGPUShadingLanguageRI/TernaryExpression.js
	D	Tools/WebGPUShadingLanguageRI/Test.html
	D	Tools/WebGPUShadingLanguageRI/Test.js
	D	Tools/WebGPUShadingLanguageRI/Texture.js
	D	Tools/WebGPUShadingLanguageRI/TextureOperations.js
	D	Tools/WebGPUShadingLanguageRI/TrapStatement.js
	D	Tools/WebGPUShadingLanguageRI/Type.js
	D	Tools/WebGPUShadingLanguageRI/TypeDef.js
	D	Tools/WebGPUShadingLanguageRI/TypeDefResolver.js
	D	Tools/WebGPUShadingLanguageRI/TypeOverloadResolutionFailure.js
	D	Tools/WebGPUShadingLanguageRI/TypeRef.js
	D	Tools/WebGPUShadingLanguageRI/TypedValue.js
	D	Tools/WebGPUShadingLanguageRI/UintLiteral.js
	D	Tools/WebGPUShadingLanguageRI/UintLiteralType.js
	D	Tools/WebGPUShadingLanguageRI/UnificationContext.js
	D	Tools/WebGPUShadingLanguageRI/UnreachableCodeChecker.js
	D	Tools/WebGPUShadingLanguageRI/Value.js
	D	Tools/WebGPUShadingLanguageRI/VariableDecl.js
	D	Tools/WebGPUShadingLanguageRI/VariableRef.js
	D	Tools/WebGPUShadingLanguageRI/VectorType.js
	D	Tools/WebGPUShadingLanguageRI/VisitingSet.js
	D	Tools/WebGPUShadingLanguageRI/Visitor.js
	D	Tools/WebGPUShadingLanguageRI/WLexicalError.js
	D	Tools/WebGPUShadingLanguageRI/WSyntaxError.js
	D	Tools/WebGPUShadingLanguageRI/WTrapError.js
	D	Tools/WebGPUShadingLanguageRI/WTypeError.js
	D	Tools/WebGPUShadingLanguageRI/WhileLoop.js
	D	Tools/WebGPUShadingLanguageRI/WrapChecker.js
	D	Tools/WebGPUShadingLanguageRI/index.html
	D	Tools/WebGPUShadingLanguageRI/spirv.core.grammar.json
	D	Tools/WebGPUShadingLanguageRI/wsl-tests.yaml
	M	Tools/ChangeLog
	D+	Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/AppIcon.appiconset/
	D+	Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/
	D+	Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/
	D+	Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Base.lproj/
	D+	Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/
	D+	Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/
	D+	Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/
	D+	Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/
	D+	Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/
	D+	Tools/WebGPUShadingLanguageRI/Metal/
	D+	Tools/WebGPUShadingLanguageRI/

ERROR from SVN:
A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output:
Commits are currently disabled while we update infrastructure.
W: 02253e88c95fe79e51e338ec88b3a20170a8d336 and refs/remotes/origin/master differ, using rebase:
:040000 040000 4a6979eb607f5bf01aef87fc49ebf5f6c7482cc8 9c8b0ceaa22b2c82d26c613ffc9416cb23f803a7 M	Tools
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: https://webkit-queues.webkit.org/results/9576762
Comment 4 WebKit Commit Bot 2018-10-15 08:55:21 PDT
Comment on attachment 352257 [details]
Patch

Clearing flags on attachment: 352257

Committed r237115: <https://trac.webkit.org/changeset/237115>
Comment 5 WebKit Commit Bot 2018-10-15 08:55:23 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-10-15 08:56:29 PDT
<rdar://problem/45272370>
Comment 7 Dawei Fenton (:realdawei) 2018-10-15 10:51:22 PDT
(In reply to WebKit Commit Bot from comment #4)
> Comment on attachment 352257 [details]
> Patch
> 
> Clearing flags on attachment: 352257
> 
> Committed r237115: <https://trac.webkit.org/changeset/237115>

Seeing this error on the JSC bots:

https://build.webkit.org/builders/Apple%20High%20Sierra%2032-bit%20JSC%20%28BuildAndTest%29/builds/2709/steps/webkit-32bit-jsc-test/logs/stdio

Tools/Scripts/run-jsc-stress-tests:1462:in `realpath': No such file or directory @ realpath_rec - /Volumes/Data/slave/highsierra-32bitJSC-debug/build/Tools/WebGPUShadingLanguageRI (Errno::ENOENT)
	from Tools/Scripts/run-jsc-stress-tests:1462:in `realpath'
	from Tools/Scripts/run-jsc-stress-tests:1462:in `prepareCollection'
	from Tools/Scripts/run-jsc-stress-tests:1560:in `handleCollectionDirectory'
	from Tools/Scripts/run-jsc-stress-tests:1582:in `handleCollection'
	from Tools/Scripts/run-jsc-stress-tests:1693:in `block in prepareBundle'
	from Tools/Scripts/run-jsc-stress-tests:1691:in `each'
	from Tools/Scripts/run-jsc-stress-tests:1691:in `prepareBundle'
	from Tools/Scripts/run-jsc-stress-tests:2060:in `runNormal'
	from Tools/Scripts/run-jsc-stress-tests:2103:in `<main>'

also:
https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20JSC%20%28Tests%29/builds/1599/steps/jscore-test/logs/stdio
Comment 8 Ryan Haddad 2018-10-15 12:20:29 PDT
(In reply to Dawei Fenton (:realdawei) from comment #7)
> (In reply to WebKit Commit Bot from comment #4)
> > Comment on attachment 352257 [details]
> > Patch
> > 
> > Clearing flags on attachment: 352257
> > 
> > Committed r237115: <https://trac.webkit.org/changeset/237115>
> 
> Seeing this error on the JSC bots:
> 
> https://build.webkit.org/builders/Apple%20High%20Sierra%2032-
> bit%20JSC%20%28BuildAndTest%29/builds/2709/steps/webkit-32bit-jsc-test/logs/
> stdio
> 
> Tools/Scripts/run-jsc-stress-tests:1462:in `realpath': No such file or
> directory @ realpath_rec -
> /Volumes/Data/slave/highsierra-32bitJSC-debug/build/Tools/
> WebGPUShadingLanguageRI (Errno::ENOENT)
> 	from Tools/Scripts/run-jsc-stress-tests:1462:in `realpath'
> 	from Tools/Scripts/run-jsc-stress-tests:1462:in `prepareCollection'
> 	from Tools/Scripts/run-jsc-stress-tests:1560:in `handleCollectionDirectory'
> 	from Tools/Scripts/run-jsc-stress-tests:1582:in `handleCollection'
> 	from Tools/Scripts/run-jsc-stress-tests:1693:in `block in prepareBundle'
> 	from Tools/Scripts/run-jsc-stress-tests:1691:in `each'
> 	from Tools/Scripts/run-jsc-stress-tests:1691:in `prepareBundle'
> 	from Tools/Scripts/run-jsc-stress-tests:2060:in `runNormal'
> 	from Tools/Scripts/run-jsc-stress-tests:2103:in `<main>'
> 
> also:
> https://build.webkit.org/builders/
> Apple%20High%20Sierra%20Debug%20JSC%20%28Tests%29/builds/1599/steps/jscore-
> test/logs/stdio

I removed WebGPUShadingLanguageRI tests from run-jsc-stress-tests script in https://trac.webkit.org/r237130