Bug 190554 – [WPT] Update resource-timing WPT tests to use the right cross origin

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jiewen Tan]

Update resource-timing WPT tests to use the right cross origin.

[Jiewen Tan]

Created attachment 352256 [details]
Patch

[EWS Watchlist]

Comment on attachment 352256 [details]
Patch

Attachment 352256 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9562894

New failing tests:
imported/w3c/web-platform-tests/resource-timing/resource_timing_cross_origin_redirect_chain.html

[EWS Watchlist]

Created attachment 352259 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Ryosuke Niwa]

This is change being made upstream? Why are we fixing the imported tests here?

[Jiewen Tan]

(In reply to Ryosuke Niwa from comment #4)
> This is change being made upstream? Why are we fixing the imported tests
> here?

Youenn told me that we could somehow fix the tests and then push to the upstream. I am trying to do what he suggested.

[EWS Watchlist]

Comment on attachment 352256 [details]
Patch

Attachment 352256 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9563050

New failing tests:
imported/w3c/web-platform-tests/resource-timing/resource_timing_cross_origin_redirect_chain.html

[EWS Watchlist]

Created attachment 352261 [details]
Archive of layout-test-results from ews117 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 352256 [details]
Patch

Attachment 352256 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9563686

New failing tests:
imported/w3c/web-platform-tests/resource-timing/resource_timing_cross_origin_redirect_chain.html

[EWS Watchlist]

Created attachment 352263 [details]
Archive of layout-test-results from ews105 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 352256 [details]
Patch

Attachment 352256 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9563586

New failing tests:
imported/w3c/web-platform-tests/resource-timing/resource_timing_cross_origin_redirect_chain.html

[EWS Watchlist]

Created attachment 352264 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Jiewen Tan]

The timing information is varied. Therefore, we see those failures. I should add a TestExpectations.

[youenn fablet]

(In reply to Jiewen Tan from comment #12)
> The timing information is varied. Therefore, we see those failures. I should
> add a TestExpectations.

Right, either you change the test to go from assert_equals to assert_true or you make the test [ Pass Failure ].

[Jiewen Tan]

(In reply to youenn fablet from comment #13)
> (In reply to Jiewen Tan from comment #12)
> > The timing information is varied. Therefore, we see those failures. I should
> > add a TestExpectations.
> 
> Right, either you change the test to go from assert_equals to assert_true or
> you make the test [ Pass Failure ].

I think the original case is well written in this part. I will write a test expectation.

[Jiewen Tan]

Created attachment 352932 [details]
Patch

[Jiewen Tan]

Created attachment 352934 [details]
Patch

[Jiewen Tan]

Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/13669

[Jiewen Tan]

Got this error:
HTTP Error 403: Forbidden
Could not add label "webkit-export" to pr #13669. User "alanwaketan" may not have permission to update labels in the web-platform-tests/wpt repo.

Does this matter?

[youenn fablet]

(In reply to Jiewen Tan from comment #18)
> Got this error:
> HTTP Error 403: Forbidden
> Could not add label "webkit-export" to pr #13669. User "alanwaketan" may not
> have permission to update labels in the web-platform-tests/wpt repo.
> 
> Does this matter?

Oh I see, I’ll handle it

[youenn fablet]

Change landed in WPT, cq+ this patch.

[WebKit Commit Bot]

Comment on attachment 352934 [details]
Patch

Clearing flags on attachment: 352934

Committed r237408: <https://trac.webkit.org/changeset/237408>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/45546624>