Bug 190554 - [WPT] Update resource-timing WPT tests to use the right cross origin
Summary: [WPT] Update resource-timing WPT tests to use the right cross origin
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-13 13:23 PDT by Jiewen Tan
Modified: 2018-10-25 00:26 PDT (History)
6 users (show)

See Also:


Attachments
Patch (7.85 KB, patch)
2018-10-13 13:30 PDT, Jiewen Tan
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-sierra (2.52 MB, application/zip)
2018-10-13 19:37 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews117 for mac-sierra (3.22 MB, application/zip)
2018-10-13 20:54 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews105 for mac-sierra-wk2 (3.11 MB, application/zip)
2018-10-13 21:25 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (2.42 MB, application/zip)
2018-10-13 21:52 PDT, EWS Watchlist
no flags Details
Patch (9.41 KB, patch)
2018-10-22 17:24 PDT, Jiewen Tan
no flags Details | Formatted Diff | Diff
Patch (9.41 KB, patch)
2018-10-22 17:36 PDT, Jiewen Tan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2018-10-13 13:23:02 PDT
Update resource-timing WPT tests to use the right cross origin.
Comment 1 Jiewen Tan 2018-10-13 13:30:31 PDT
Created attachment 352256 [details]
Patch
Comment 2 EWS Watchlist 2018-10-13 19:37:27 PDT
Comment on attachment 352256 [details]
Patch

Attachment 352256 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9562894

New failing tests:
imported/w3c/web-platform-tests/resource-timing/resource_timing_cross_origin_redirect_chain.html
Comment 3 EWS Watchlist 2018-10-13 19:37:29 PDT
Created attachment 352259 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 4 Ryosuke Niwa 2018-10-13 20:32:05 PDT
This is change being made upstream? Why are we fixing the imported tests here?
Comment 5 Jiewen Tan 2018-10-13 20:45:51 PDT
(In reply to Ryosuke Niwa from comment #4)
> This is change being made upstream? Why are we fixing the imported tests
> here?

Youenn told me that we could somehow fix the tests and then push to the upstream. I am trying to do what he suggested.
Comment 6 EWS Watchlist 2018-10-13 20:54:28 PDT
Comment on attachment 352256 [details]
Patch

Attachment 352256 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9563050

New failing tests:
imported/w3c/web-platform-tests/resource-timing/resource_timing_cross_origin_redirect_chain.html
Comment 7 EWS Watchlist 2018-10-13 20:54:30 PDT
Created attachment 352261 [details]
Archive of layout-test-results from ews117 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 8 EWS Watchlist 2018-10-13 21:25:56 PDT
Comment on attachment 352256 [details]
Patch

Attachment 352256 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9563686

New failing tests:
imported/w3c/web-platform-tests/resource-timing/resource_timing_cross_origin_redirect_chain.html
Comment 9 EWS Watchlist 2018-10-13 21:25:58 PDT
Created attachment 352263 [details]
Archive of layout-test-results from ews105 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 10 EWS Watchlist 2018-10-13 21:52:21 PDT
Comment on attachment 352256 [details]
Patch

Attachment 352256 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9563586

New failing tests:
imported/w3c/web-platform-tests/resource-timing/resource_timing_cross_origin_redirect_chain.html
Comment 11 EWS Watchlist 2018-10-13 21:52:22 PDT
Created attachment 352264 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 12 Jiewen Tan 2018-10-15 12:28:38 PDT
The timing information is varied. Therefore, we see those failures. I should add a TestExpectations.
Comment 13 youenn fablet 2018-10-15 13:28:51 PDT
(In reply to Jiewen Tan from comment #12)
> The timing information is varied. Therefore, we see those failures. I should
> add a TestExpectations.

Right, either you change the test to go from assert_equals to assert_true or you make the test [ Pass Failure ].
Comment 14 Jiewen Tan 2018-10-22 17:18:43 PDT
(In reply to youenn fablet from comment #13)
> (In reply to Jiewen Tan from comment #12)
> > The timing information is varied. Therefore, we see those failures. I should
> > add a TestExpectations.
> 
> Right, either you change the test to go from assert_equals to assert_true or
> you make the test [ Pass Failure ].

I think the original case is well written in this part. I will write a test expectation.
Comment 15 Jiewen Tan 2018-10-22 17:24:10 PDT
Created attachment 352932 [details]
Patch
Comment 16 Jiewen Tan 2018-10-22 17:36:42 PDT
Created attachment 352934 [details]
Patch
Comment 17 Jiewen Tan 2018-10-22 17:37:02 PDT
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/13669
Comment 18 Jiewen Tan 2018-10-22 17:44:03 PDT
Got this error:
HTTP Error 403: Forbidden
Could not add label "webkit-export" to pr #13669. User "alanwaketan" may not have permission to update labels in the web-platform-tests/wpt repo.

Does this matter?
Comment 19 youenn fablet 2018-10-23 03:28:13 PDT
(In reply to Jiewen Tan from comment #18)
> Got this error:
> HTTP Error 403: Forbidden
> Could not add label "webkit-export" to pr #13669. User "alanwaketan" may not
> have permission to update labels in the web-platform-tests/wpt repo.
> 
> Does this matter?

Oh I see, I’ll handle it
Comment 20 youenn fablet 2018-10-24 23:59:35 PDT
Change landed in WPT, cq+ this patch.
Comment 21 WebKit Commit Bot 2018-10-25 00:25:06 PDT
Comment on attachment 352934 [details]
Patch

Clearing flags on attachment: 352934

Committed r237408: <https://trac.webkit.org/changeset/237408>
Comment 22 WebKit Commit Bot 2018-10-25 00:25:08 PDT
All reviewed patches have been landed.  Closing bug.
Comment 23 Radar WebKit Bug Importer 2018-10-25 00:26:37 PDT
<rdar://problem/45546624>