Bug 190544 - Perf dashboard: add a test for aggregating subtests without a matching metric in /api/report
Summary: Perf dashboard: add a test for aggregating subtests without a matching metric...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Perf Dashboard (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-12 15:47 PDT by Ryosuke Niwa
Modified: 2018-10-12 16:11 PDT (History)
6 users (show)

See Also:

Attachments
Adds tests (10.49 KB, patch)
2018-10-12 15:56 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Patch for landing (10.35 KB, patch)
2018-10-12 16:07 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2018-10-12 15:47:02 PDT 
Add a test for /api/report to aggregate subtests one of which is missing the matching metric.
The aggregator should simply skip that subtest.
Comment 1 Ryosuke Niwa 2018-10-12 15:56:46 PDT 
Created attachment 352222 [details]
Adds tests
Comment 2 Keith Miller 2018-10-12 15:58:00 PDT 
Comment on attachment 352222 [details]
Adds tests

rs=me.
Comment 3 dewei_zhu 2018-10-12 16:01:38 PDT 
Comment on attachment 352222 [details]
Adds tests

View in context: https://bugs.webkit.org/attachment.cgi?id=352222&action=review

> Websites/perf.webkit.org/server-tests/api-report-tests.js:619
> +                "DummyBenchmark": {

Not important, this indentation doesn't seem to be consistent with others.
Comment 4 dewei_zhu 2018-10-12 16:01:57 PDT 
Looks good to me.
Comment 5 Ryosuke Niwa 2018-10-12 16:03:42 PDT 
(In reply to dewei_zhu from comment #3)
> Comment on attachment 352222 [details]
> Adds tests
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=352222&action=review
> 
> > Websites/perf.webkit.org/server-tests/api-report-tests.js:619
> > +                "DummyBenchmark": {
> 
> Not important, this indentation doesn't seem to be consistent with others.

Oh good catch. I don't know what happened there. Fixed!
Comment 6 dewei_zhu 2018-10-12 16:04:49 PDT 
Comment on attachment 352222 [details]
Adds tests

View in context: https://bugs.webkit.org/attachment.cgi?id=352222&action=review

> Websites/perf.webkit.org/server-tests/api-report-tests.js:670
> +                "DummyBenchmark": {

Ditto here.
Comment 7 Ryosuke Niwa 2018-10-12 16:07:04 PDT 
Created attachment 352227 [details]
Patch for landing
Comment 8 Ryosuke Niwa 2018-10-12 16:10:42 PDT 
Comment on attachment 352227 [details]
Patch for landing

Clearing flags on attachment: 352227

Committed r237086: <https://trac.webkit.org/changeset/237086>
Comment 9 Ryosuke Niwa 2018-10-12 16:10:45 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2018-10-12 16:11:41 PDT 
<rdar://problem/45240758>