Bug 190544 – Perf dashboard: add a test for aggregating subtests without a matching metric in /api/report

• Status: RESOLVED
• Resolution: FIXED
• Component: Perf Dashboard

[Ryosuke Niwa]

Add a test for /api/report to aggregate subtests one of which is missing the matching metric.
The aggregator should simply skip that subtest.

[Ryosuke Niwa]

Created attachment 352222 [details]
Adds tests

[Keith Miller]

Comment on attachment 352222 [details]
Adds tests

rs=me.

Comment on attachment 352222 [details]
Adds tests

View in context: https://bugs.webkit.org/attachment.cgi?id=352222&action=review

> Websites/perf.webkit.org/server-tests/api-report-tests.js:619
> +                "DummyBenchmark": {

Not important, this indentation doesn't seem to be consistent with others.

Looks good to me.

[Ryosuke Niwa]

(In reply to dewei_zhu from comment #3)
> Comment on attachment 352222 [details]
> Adds tests
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=352222&action=review
> 
> > Websites/perf.webkit.org/server-tests/api-report-tests.js:619
> > +                "DummyBenchmark": {
> 
> Not important, this indentation doesn't seem to be consistent with others.

Oh good catch. I don't know what happened there. Fixed!

Comment on attachment 352222 [details]
Adds tests

View in context: https://bugs.webkit.org/attachment.cgi?id=352222&action=review

> Websites/perf.webkit.org/server-tests/api-report-tests.js:670
> +                "DummyBenchmark": {

Ditto here.

[Ryosuke Niwa]

Created attachment 352227 [details]
Patch for landing

[Ryosuke Niwa]

Comment on attachment 352227 [details]
Patch for landing

Clearing flags on attachment: 352227

Committed r237086: <https://trac.webkit.org/changeset/237086>

[Ryosuke Niwa]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/45240758>