Bug 190542 - Web Inspector: Dark Mode: selected text is too light when Inspector window is inactive
Summary: Web Inspector: Dark Mode: selected text is too light when Inspector window is...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
: 188112 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-10-12 15:04 PDT by Matt Baker
Modified: 2018-12-19 13:09 PST (History)
4 users (show)

See Also:


Attachments
[Image] Inactive window with text selection (445.07 KB, image/png)
2018-10-12 15:04 PDT, Matt Baker
no flags Details
Patch (1.25 KB, patch)
2018-12-18 23:32 PST, Nikita Vasilyev
no flags Details | Formatted Diff | Diff
[Image] With patch applied (72.80 KB, image/png)
2018-12-18 23:33 PST, Nikita Vasilyev
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2018-10-12 15:04:57 PDT
Created attachment 352213 [details]
[Image] Inactive window with text selection

This seems similar to https://bugs.webkit.org/show_bug.cgi?id=188112, but may be a separate issue. I'll leave it up to you!
Comment 1 Radar WebKit Bug Importer 2018-10-12 15:05:25 PDT
<rdar://problem/45238712>
Comment 2 Nikita Vasilyev 2018-12-18 23:32:23 PST
Created attachment 357662 [details]
Patch

This turned out to be simply a CodeMirror issue. Trivial fix!
Comment 3 Nikita Vasilyev 2018-12-18 23:33:30 PST
Created attachment 357663 [details]
[Image] With patch applied
Comment 4 Nikita Vasilyev 2018-12-18 23:36:21 PST
*** Bug 188112 has been marked as a duplicate of this bug. ***
Comment 5 Devin Rousso 2018-12-19 12:43:41 PST
Comment on attachment 357662 [details]
Patch

rs=me, nice fix
Comment 6 WebKit Commit Bot 2018-12-19 13:09:52 PST
Comment on attachment 357662 [details]
Patch

Clearing flags on attachment: 357662

Committed r239386: <https://trac.webkit.org/changeset/239386>
Comment 7 WebKit Commit Bot 2018-12-19 13:09:53 PST
All reviewed patches have been landed.  Closing bug.