Bug 190541 – Web Inspector: Dark Mode: pseudo elements in DOM tree are too dark

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

Created attachment 352210 [details]
[Image] Bug

It's hard to read. The text should be lighter.

[Radar WebKit Bug Importer]

<rdar://problem/45238443>

[Nikita Vasilyev]

Created attachment 352235 [details]
Patch

[Nikita Vasilyev]

Created attachment 352237 [details]
[Image] With patch applied

[Matt Baker]

Comment on attachment 352235 [details]
Patch

Looks good! r=me

[WebKit Commit Bot]

Comment on attachment 352235 [details]
Patch

Rejecting attachment 352235 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 352235, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=352235&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=190541&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 352235 from bug 190541.
Fetching: https://bugs.webkit.org/attachment.cgi?id=352235
Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebInspectorUI/ChangeLog
	M	Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css

ERROR from SVN:
A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output:
Commits are currently disabled while we update infrastructure.
W: 7644547ba76efb3b3768320bf9483caa9b34ba69 and refs/remotes/origin/master differ, using rebase:
:040000 040000 4ca24894a3780f512730e762268d590b936f190e db349c7d53434e63104b36e19511df8a3253ad7d M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebInspectorUI/ChangeLog
	M	Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css

ERROR from SVN:
A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output:
Commits are currently disabled while we update infrastructure.
W: 7644547ba76efb3b3768320bf9483caa9b34ba69 and refs/remotes/origin/master differ, using rebase:
:040000 040000 4ca24894a3780f512730e762268d590b936f190e db349c7d53434e63104b36e19511df8a3253ad7d M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
From https://git.webkit.org/git/WebKit
   eaa251f4427..2fde85661b4  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 237089 = eaa251f4427efa277b980c9fd8a09482dcfe0f06
r237090 = c0de3e0d64fefa6d1ffab293dcbe3fe23a87a49c
r237091 = 2fde85661b4bf2a3ad6344694401d91e9220e99e
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: https://webkit-queues.webkit.org/results/9559825

[WebKit Commit Bot]

Comment on attachment 352235 [details]
Patch

Clearing flags on attachment: 352235

Committed r237150: <https://trac.webkit.org/changeset/237150>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.