Bug 190533 - Use downcast for use of RealtimeMediaSource in LibWebRTCMediaEndpoint
Summary: Use downcast for use of RealtimeMediaSource in LibWebRTCMediaEndpoint
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-12 13:14 PDT by youenn fablet
Modified: 2018-10-12 15:07 PDT (History)
6 users (show)

See Also:

Attachments
Patch (5.07 KB, patch)
2018-10-12 13:17 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (5.03 KB, patch)
2018-10-12 13:44 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-10-12 13:14:20 PDT 
Use downcast for use of RealtimeMediaSource in LibWebRTCMediaEndpoint
Comment 1 youenn fablet 2018-10-12 13:17:27 PDT 
Created attachment 352194 [details]
Patch
Comment 2 EWS Watchlist 2018-10-12 13:19:59 PDT 
Attachment 352194 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSource.h:165:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSource.h:166:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 youenn fablet 2018-10-12 13:44:42 PDT 
Created attachment 352196 [details]
Patch
Comment 4 EWS Watchlist 2018-10-12 13:47:53 PDT 
Attachment 352196 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSource.h:165:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSource.h:166:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Chris Dumez 2018-10-12 14:37:08 PDT 
Comment on attachment 352196 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2018-10-12 15:06:14 PDT 
Comment on attachment 352196 [details]
Patch

Clearing flags on attachment: 352196

Committed r237082: <https://trac.webkit.org/changeset/237082>
Comment 7 WebKit Commit Bot 2018-10-12 15:06:16 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-10-12 15:07:25 PDT 
<rdar://problem/45238780>