RESOLVED FIXED 190517
[PSON] Prewarm system fallback fonts 
https://bugs.webkit.org/show_bug.cgi?id=190517
Summary [PSON] Prewarm system fallback fonts
Antti Koivisto
Reported 2018-10-12 05:21:07 PDT
Looking for system fallbacks is expensive. We can prewarm them for processes that are likely need them.
Attachments
patch (10.83 KB, patch)
2018-10-12 05:32 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (10.90 KB, patch)
2018-10-12 06:42 PDT, Antti Koivisto 		rniwa: review+
DetailsFormatted DiffDiff
patch (10.91 KB, patch)
2018-10-15 04:46 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (10.80 KB, patch)
2018-10-15 04:53 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (10.65 KB, patch)
2018-10-15 08:25 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2018-10-12 05:32:01 PDT
Created attachment 352159 [details] patch
Antti Koivisto
Comment 2 2018-10-12 06:42:14 PDT
Created attachment 352165 [details] patch
Ryosuke Niwa
Comment 3 2018-10-12 10:09:22 PDT
Comment on attachment 352165 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=352165&action=review > Source/WebCore/page/ProcessWarming.cpp:93 > + prewarmInformation.fontCache = FontCache::singleton().collectPrewarmInformation(); > + return prewarmInformation; Can't we just do this?: return { FontCache::singleton().collectPrewarmInformation() }; > Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1538 > + if (prewarmInformation.seenFamilies.isEmpty() && prewarmInformation.fontNamesRequiringSystemFallback.isEmpty()) Maybe we can add PrewarmInformation::isEmpty?
Antti Koivisto
Comment 4 2018-10-15 04:46:55 PDT
Created attachment 352308 [details] patch
Antti Koivisto
Comment 5 2018-10-15 04:53:29 PDT
Created attachment 352310 [details] patch
Antti Koivisto
Comment 6 2018-10-15 08:25:29 PDT
Created attachment 352323 [details] patch
WebKit Commit Bot
Comment 7 2018-10-15 09:02:45 PDT
Comment on attachment 352323 [details] patch Clearing flags on attachment: 352323 Committed r237116: <https://trac.webkit.org/changeset/237116>
WebKit Commit Bot
Comment 8 2018-10-15 09:02:46 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-10-15 09:03:44 PDT
<rdar://problem/45272576>
Note You need to log in before you can comment on or make changes to this bug.