Bug 190510 – Web Inspector: Dark Mode: Highlight text in Network Headers search is too dark

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Web Inspector: Dark Mode: Highlight text in Network Headers search is too dark

Steps to Reproduce:
•. Use Dark Mode
1. Inspect this page
2. Show Network Tab
3. Select a Resource
4. Show Headers Pane
5. ⌘F to search for a string
  => Highlights look bad

[Joseph Pecoraro]

Created attachment 352129 [details]
[PATCH] Proposed Fix

[Devin Rousso]

Comment on attachment 352129 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=352129&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/ResourceHeadersContentView.css:82
> +    color: var(--text-color);

It seems weird to me that we'd color the header keys too (instead of using the existing current color) , but I suppose that blue-on-yellow isn't much better :|

If we did, you could drop this `color` altogether, since the `.value` already uses `--text-color`.

[Nikita Vasilyev]

I don't think I even knew that there's search in the headers pane.

This fix is fine. Eventually, I'd like to unify highlight styles. Search highlights are used in DOM tree outline, styles sidebar, resource content view, console, search tab, and a few other places. We should make them look the same and, possibly, even use the same CSS rule everywhere.

[WebKit Commit Bot]

Comment on attachment 352129 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 352129

Committed r237085: <https://trac.webkit.org/changeset/237085>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/45240487>