Bug 19051 – REGRESSION (r33447): Assertion in JSDebugServer::removeListener when closing tab with Inspector open

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Matt Lilek]

Closing a tab in r33447 crashes because of:

<http://trac.webkit.org/browser/trunk/WebCore/page/JavaScriptDebugServer.cpp#L109>
ARGUMENT BAD: page, page
(/Users/matt/Code/WebKit/WebCore/page/JavaScriptDebugServer.cpp:109 void WebCore::JavaScriptDebugServer::removeListener(WebCore::JavaScriptDebugListener*, WebCore::Page*))

Thread 0 Crashed:
0   com.apple.WebCore             	0x02a20e42 WebCore::JavaScriptDebugServer::removeListener(WebCore::JavaScriptDebugListener*, WebCore::Page*) + 78 (JavaScriptDebugServer.cpp:109)
1   com.apple.WebCore             	0x025dc3bc WebCore::InspectorController::stopDebugging() + 38 (InspectorController.cpp:2076)
2   com.apple.WebCore             	0x025e098d WebCore::InspectorController::~InspectorController() + 347
3   com.apple.WebCore             	0x0271531e void WTF::deleteOwnedPtr<WebCore::InspectorController>(WebCore::InspectorController*) + 30 (OwnPtr.h:52)
4   com.apple.WebCore             	0x02715333 WTF::OwnPtr<WebCore::InspectorController>::~OwnPtr() + 19
5   com.apple.WebCore             	0x02714410 WebCore::Page::~Page() + 462
6   com.apple.WebKit              	0x0022ff7d -[WebView(WebPrivate) _close] + 475 (WebView.mm:729)

[Adam Roben (:aroben)]

Created attachment 21131 [details]
patch with ChangeLog

[Dave Hyatt]

Comment on attachment 21131 [details]
patch with ChangeLog

r=me

[Eric Seidel (no email)]

*** Bug 19056 has been marked as a duplicate of this bug. ***

[Adam Roben (:aroben)]

Committed in r33450.