Bug 190495 - Hardware keyboard arrow keys/spacebar don't scroll PDFs (works for web content)
Summary: Hardware keyboard arrow keys/spacebar don't scroll PDFs (works for web content)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-11 15:20 PDT by Tim Horton
Modified: 2018-10-11 16:41 PDT (History)
5 users (show)

See Also:

Attachments
Patch (16.73 KB, patch)
2018-10-11 15:21 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (21.55 KB, patch)
2018-10-11 15:23 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (21.64 KB, patch)
2018-10-11 16:02 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (21.64 KB, patch)
2018-10-11 16:03 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2018-10-11 15:20:17 PDT 
Hardware keyboard arrow keys/spacebar don't scroll PDFs (works for web content)
Comment 1 Tim Horton 2018-10-11 15:21:57 PDT 
Created attachment 352091 [details]
Patch
Comment 2 Tim Horton 2018-10-11 15:21:59 PDT 
<rdar://problem/22734616>
Comment 3 Tim Horton 2018-10-11 15:22:31 PDT 
Comment on attachment 352091 [details]
Patch

The new files are missing...
Comment 4 Tim Horton 2018-10-11 15:23:10 PDT 
Created attachment 352092 [details]
Patch
Comment 5 Andy Estes 2018-10-11 15:38:11 PDT 
Comment on attachment 352092 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352092&action=review

> Source/WebKit/UIProcess/ios/WKPDFView.mm:85
> +    ::WebEvent *webEvent = [[[WKWebEvent alloc] initWithEvent:event] autorelease];

auto webEvent = adoptNS(...?
Comment 6 Tim Horton 2018-10-11 15:59:00 PDT 
Sure why not
Comment 7 Tim Horton 2018-10-11 16:02:34 PDT 
Created attachment 352097 [details]
Patch
Comment 8 Tim Horton 2018-10-11 16:03:44 PDT 
Created attachment 352098 [details]
Patch
Comment 9 Tim Horton 2018-10-11 16:41:36 PDT 
https://trac.webkit.org/changeset/237053/webkit