Bug 190486 - [WTF] Semaphore.h conflicts with POSIX header
Summary: [WTF] Semaphore.h conflicts with POSIX header
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-11 14:23 PDT by Don Olmstead
Modified: 2018-10-11 15:54 PDT (History)
3 users (show)

See Also:

Attachments
Patch (12.46 KB, patch)
2018-10-11 14:40 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2018-10-11 14:23:59 PDT 
In https://trac.webkit.org/changeset/236101/webkit Semaphore.h was added to WTF. This can conflict with the POSIX semaphore.h on file systems that are case-insensitive.

Propose to rename it to WTFSemaphore which is a similar route to WTFString.
Comment 1 Ross Kirsling 2018-10-11 14:40:26 PDT 
Created attachment 352081 [details]
Patch
Comment 2 Yusuke Suzuki 2018-10-11 15:10:24 PDT 
Comment on attachment 352081 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2018-10-11 15:52:50 PDT 
Comment on attachment 352081 [details]
Patch

Clearing flags on attachment: 352081

Committed r237052: <https://trac.webkit.org/changeset/237052>
Comment 4 WebKit Commit Bot 2018-10-11 15:52:52 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-10-11 15:54:03 PDT 
<rdar://problem/45209633>