Bug 190485 - CRASH in WebCore::MediaPlayerPrivateAVFoundation::setPreload
Summary: CRASH in WebCore::MediaPlayerPrivateAVFoundation::setPreload
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-11 14:18 PDT by Jer Noble
Modified: 2018-10-12 08:28 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.73 KB, patch)
2018-10-11 14:24 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (2.72 KB, patch)
2018-10-11 14:47 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews112 for mac-sierra (3.19 MB, application/zip)
2018-10-11 16:40 PDT, EWS Watchlist 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2018-10-11 14:18:15 PDT 
CRASH in WebCore::MediaPlayerPrivateAVFoundation::setPreload
Comment 1 Jer Noble 2018-10-11 14:18:54 PDT 
<rdar://problem/34613350>
Comment 2 Jer Noble 2018-10-11 14:24:51 PDT 
Created attachment 352077 [details]
Patch
Comment 3 Eric Carlson 2018-10-11 14:29:21 PDT 
Comment on attachment 352077 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352077&action=review

> Source/WebCore/ChangeLog:13
> +        HTMLMediaElement). Code inspection hasn't yielded any good hints about why this might be occurring, so we wil

Nit: s/we wil/we will/
Comment 4 Jer Noble 2018-10-11 14:47:12 PDT 
Created attachment 352082 [details]
Patch for landing
Comment 5 EWS Watchlist 2018-10-11 16:40:18 PDT 
Comment on attachment 352082 [details]
Patch for landing

Attachment 352082 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9542413

New failing tests:
legacy-animation-engine/accessibility/content-changed-notification-causes-crash.html
Comment 6 EWS Watchlist 2018-10-11 16:40:20 PDT 
Created attachment 352102 [details]
Archive of layout-test-results from ews112 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 7 WebKit Commit Bot 2018-10-12 08:28:47 PDT 
Comment on attachment 352082 [details]
Patch for landing

Clearing flags on attachment: 352082

Committed r237067: <https://trac.webkit.org/changeset/237067>
Comment 8 WebKit Commit Bot 2018-10-12 08:28:48 PDT 
All reviewed patches have been landed.  Closing bug.