Bug 190481 - Experiment: target=_blank on anchors should imply rel=noopener
Summary: Experiment: target=_blank on anchors should imply rel=noopener
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://github.com/whatwg/html/issues...
Keywords: InRadar
Depends on: 190475
Blocks:
  Show dependency treegraph
 
Reported: 2018-10-11 13:33 PDT by Chris Dumez
Modified: 2019-01-24 07:48 PST (History)
11 users (show)

See Also:


Attachments
WIP Patch (needs dependency to land) (14.42 KB, patch)
2018-10-11 14:21 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
WIP Patch (needs dependency to land) (14.42 KB, patch)
2018-10-11 14:23 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
WIP Patch (needs dependency to land) (14.31 KB, patch)
2018-10-11 15:05 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (20.85 KB, patch)
2018-10-15 10:07 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (21.01 KB, patch)
2018-10-15 10:12 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-10-11 13:33:19 PDT
As an experiment, try and make it so that target=_blank on anchors implies `rel=noopener` for improved security. WebContent can then request an opener relationship by using `rel=opener` instead.
Comment 1 Chris Dumez 2018-10-11 14:21:45 PDT
Created attachment 352075 [details]
WIP Patch (needs dependency to land)
Comment 2 Chris Dumez 2018-10-11 14:23:01 PDT
Created attachment 352076 [details]
WIP Patch (needs dependency to land)
Comment 3 Chris Dumez 2018-10-11 15:05:47 PDT
Created attachment 352087 [details]
WIP Patch (needs dependency to land)
Comment 4 Chris Dumez 2018-10-15 10:07:13 PDT
Created attachment 352336 [details]
Patch
Comment 5 EWS Watchlist 2018-10-15 10:08:56 PDT
Attachment 352336 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:283:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:286:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:290:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:292:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 4 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Chris Dumez 2018-10-15 10:12:49 PDT
Created attachment 352337 [details]
Patch
Comment 7 EWS Watchlist 2018-10-15 10:14:39 PDT
Attachment 352337 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:283:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:286:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:290:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:292:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 4 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 WebKit Commit Bot 2018-10-15 14:21:15 PDT
Comment on attachment 352337 [details]
Patch

Clearing flags on attachment: 352337

Committed r237144: <https://trac.webkit.org/changeset/237144>
Comment 9 WebKit Commit Bot 2018-10-15 14:21:17 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2018-10-15 14:22:26 PDT
<rdar://problem/45284150>