Bug 190477 - Add PLATFORM(IOS_FAMILY) and OS(IOS_FAMILY)
Summary: Add PLATFORM(IOS_FAMILY) and OS(IOS_FAMILY)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-11 13:08 PDT by Alexey Proskuryakov
Modified: 2018-10-12 09:59 PDT (History)
12 users (show)

See Also:

Attachments
proposed patch (5.90 KB, patch)
2018-10-11 13:12 PDT, Alexey Proskuryakov 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2018-10-11 13:08:51 PDT 
Currently, PLATFORM(IOS) and OS(IOS) are true when building for any TARGET_OS_IPHONE target, which is quite confusing.

Add a better named alternative, as a first step towards mass replacing PLATFORM(IOS). Can't so it all at once because of dependencies in other source repositories.
Comment 1 Alexey Proskuryakov 2018-10-11 13:12:26 PDT 
Created attachment 352068 [details]
proposed patch
Comment 2 Tim Horton 2018-10-11 13:13:06 PDT 
Earlier suggestion was PLATFORM(COCOA_TOUCH). Technically that does include all UIKitty platforms even if they don't have touch proper.
Comment 3 Alexey Proskuryakov 2018-10-11 13:29:08 PDT 
Do you like that earlier suggestion more? I do not.
Comment 4 Tim Horton 2018-10-11 15:47:27 PDT 
Comment on attachment 352068 [details]
proposed patch

I'd like to hear more r+ of the name first, but the approach is fine
Comment 5 mitz 2018-10-11 16:15:33 PDT 
Of the names proposed so far, I prefer the one in the patch.
Comment 6 Alexey Proskuryakov 2018-10-12 09:58:40 PDT 
Committed http://trac.webkit.org/r237069
Comment 7 Radar WebKit Bug Importer 2018-10-12 09:59:21 PDT 
<rdar://problem/45228899>