Bug 190474 - Regression(PSON): Deal with the drawing area potentially being null under WebChromeClient::contentsSizeChanged()
Summary: Regression(PSON): Deal with the drawing area potentially being null under Web...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-11 09:09 PDT by Chris Dumez
Modified: 2018-10-11 10:26 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.57 KB, patch)
2018-10-11 09:10 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-10-11 09:09:24 PDT 
Deal with the drawing area potentially being null under WebChromeClient::contentsSizeChanged():
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.apple.WebKit              	0x0000000106858c6d WebKit::WebChromeClient::contentsSizeChanged(WebCore::Frame&, WebCore::IntSize const&) const + 333 (WebChromeClient.cpp:600)
1   com.apple.WebCore             	0x0000000117de28c9 WebCore::Chrome::contentsSizeChanged(WebCore::Frame&, WebCore::IntSize const&) const + 73 (Chrome.cpp:136)
2   com.apple.WebCore             	0x0000000117e68d6c WebCore::FrameView::setContentsSize(WebCore::IntSize const&) + 204 (FrameView.cpp:628)
3   com.apple.WebCore             	0x0000000117e6058f WebCore::FrameView::adjustViewSize() + 687 (FrameView.cpp:650)
4   com.apple.WebCore             	0x0000000117e63468 WebCore::FrameViewLayoutContext::layout() + 2392 (FrameViewLayoutContext.cpp:228)
5   com.apple.WebCore             	0x0000000117e5b66c WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive() + 300 (FrameView.cpp:4295)
6   com.apple.WebCore             	0x0000000117e279da WebCore::EventHandler::hitTestResultAtPoint(WebCore::LayoutPoint const&, unsigned int, WebCore::LayoutSize const&) const + 906
7   com.apple.WebKit              	0x000000010690eb68 WebKit::WebFrame::hitTest(WebCore::IntPoint) const + 168 (WebFrame.cpp:639)
8   com.apple.WebKit              	0x000000010674f1b1 WKBundleFrameCreateHitTestResult + 65 (WKBundleFrame.cpp:273)
9   com.apple.Safari.framework    	0x000000012944072b Safari::WK::BundleFrame::hitTest(CGPoint) const + 155 (BundleFrame.mm:236)
Comment 1 Chris Dumez 2018-10-11 09:10:10 PDT 
Created attachment 352048 [details]
Patch
Comment 2 Geoffrey Garen 2018-10-11 09:59:16 PDT 
Comment on attachment 352048 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2018-10-11 10:25:26 PDT 
Comment on attachment 352048 [details]
Patch

Clearing flags on attachment: 352048

Committed r237035: <https://trac.webkit.org/changeset/237035>
Comment 4 WebKit Commit Bot 2018-10-11 10:25:27 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-10-11 10:26:32 PDT 
<rdar://problem/45197158>