.
Created attachment 352046 [details] Patch
Comment on attachment 352046 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352046&action=review > Source/WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:168 > } If it is necessary to add the flag, I suggest like this: gst_structure_set_name(outgoingStructure.get(), #if GST_CHECK_VERSION(1, 15, 0) !g_strcmp0(klass->protectionSystemId, GST_PROTECTION_UNSPECIFIED_SYSTEM_ID) ? "application/x-webm-enc" : "application/x-cenc"); #else "application/x-cenc"); #endif
Created attachment 352047 [details] Patch
Comment on attachment 352047 [details] Patch There is another occurence of `GST_PROTECTION_UNSPECIFIED_SYSTEM_ID` in MediaPlayerPrivateGStreamerBase.cpp - I guess you missed a part of your patch.
Comment on attachment 352047 [details] Patch Oops. Will update the patch. Thanks!
Created attachment 352177 [details] Patch
Comment on attachment 352177 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352177&action=review Lgtm, though I believe that code should be reworked :-) Informal r+ > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:1305 > + if (eventKeySystemUUID == GST_PROTECTION_UNSPECIFIED_SYSTEM_ID) I know this patch doesn't change the semantics but the assumption that `GST_PROTECTION_UNSPECIFIED_SYSTEM_ID` implies `webm` sounds dangerous/not future proof.
Comment on attachment 352177 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352177&action=review >> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:1305 >> + if (eventKeySystemUUID == GST_PROTECTION_UNSPECIFIED_SYSTEM_ID) > > I know this patch doesn't change the semantics but the assumption that `GST_PROTECTION_UNSPECIFIED_SYSTEM_ID` implies `webm` sounds dangerous/not future proof. I agree and I already commented it on the original bug. I'll buy it for the moment as in cenc the sys id is mandatory and we only suppory either webm or cenc.
Committed r237092: <https://trac.webkit.org/changeset/237092>
<rdar://problem/45268472>
I am afraid that will actually make the patches that backported that feature in jhbuild useless.
(In reply to Thibault Saunier from comment #11) > I am afraid that will actually make the patches that backported that feature > in jhbuild useless. Yes you're right. See also https://bugs.webkit.org/show_bug.cgi?id=189238#c9 and following comments.