Bug 190465 – Fix build error with !LOG_DISABLED in Release mode

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Charlie Turner]

Fix build error with !LOG_DISABLED in Release mode

[Charlie Turner]

Created attachment 352034 [details]
Patch

[Charlie Turner]

Created attachment 352304 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 352304 [details]
Patch for landing

Rejecting attachment 352304 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 352304, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=352304&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=190465&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 352304 from bug 190465.
Fetching: https://bugs.webkit.org/attachment.cgi?id=352304
Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebCore/ChangeLog
	M	Source/WebCore/workers/service/ServiceWorkerRegistrationKey.cpp
	M	Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h

ERROR from SVN:
A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output:
Commits are currently disabled while we update infrastructure.
W: 8505ca18e9a2a9550a02430dd969aff801f25597 and refs/remotes/origin/master differ, using rebase:
:040000 040000 75fcdfc48799f08707a75d542ad43fc9622dc0fe db349c7d53434e63104b36e19511df8a3253ad7d M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebCore/ChangeLog
	M	Source/WebCore/workers/service/ServiceWorkerRegistrationKey.cpp
	M	Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h

ERROR from SVN:
A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output:
Commits are currently disabled while we update infrastructure.
W: 8505ca18e9a2a9550a02430dd969aff801f25597 and refs/remotes/origin/master differ, using rebase:
:040000 040000 75fcdfc48799f08707a75d542ad43fc9622dc0fe db349c7d53434e63104b36e19511df8a3253ad7d M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: https://webkit-queues.webkit.org/results/9578495

[Charlie Turner]

Created attachment 352333 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 352333 [details]
Patch for landing

Rejecting attachment 352333 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 352333, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/9586548

[Charlie Turner]

Created attachment 352334 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 352334 [details]
Patch for landing

Clearing flags on attachment: 352334

Committed r237126: <https://trac.webkit.org/changeset/237126>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.