RESOLVED FIXED 190457
Hide RenderLayer z-order and normal flow lists behind iterators 
https://bugs.webkit.org/show_bug.cgi?id=190457
Summary Hide RenderLayer z-order and normal flow lists behind iterators
Simon Fraser (smfr)
Reported 2018-10-10 20:05:19 PDT
Hide RenderLayer z-order and normal flow lists behind iterators
Attachments
Patch (41.40 KB, patch)
2018-10-10 20:07 PDT, Simon Fraser (smfr) 		zalan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2018-10-10 20:07:17 PDT
Created attachment 352011 [details] Patch
zalan
Comment 2 2018-10-10 21:04:49 PDT
Comment on attachment 352011 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352011&action=review > Source/WebCore/rendering/RenderLayer.h:373 > + iterator begin() { return m_layerList ? m_layerList->begin() : nullptr; } > + iterator end() { return m_layerList ? m_layerList->end() : nullptr; } > + > + reverse_iterator rbegin() { return reverse_iterator(end()); } > + reverse_iterator rend() { return reverse_iterator(begin()); } It's a bit odd that a class named Iterator has functions like these.
Simon Fraser (smfr)
Comment 3 2018-10-11 09:36:04 PDT
LayerIterable? LayerList?
zalan
Comment 4 2018-10-11 13:36:47 PDT
(In reply to Simon Fraser (smfr) from comment #3) > LayerIterable? LayerList? LayerList is fine.
Simon Fraser (smfr)
Comment 5 2018-11-07 07:01:29 PST
https://trac.webkit.org/changeset/237058/webkit
Radar WebKit Bug Importer
Comment 6 2018-11-07 07:03:17 PST
<rdar://problem/45874621>
Note You need to log in before you can comment on or make changes to this bug.