Bug 190443 - Web Inspector: Network: detail view reverts to "Response" when new requests are added
Summary: Web Inspector: Network: detail view reverts to "Response" when new requests a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-10 14:30 PDT by Devin Rousso
Modified: 2018-10-11 19:31 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.55 KB, patch)
2018-10-10 14:38 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (1.66 KB, patch)
2018-10-10 22:31 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2018-10-10 14:30:36 PDT
* STEPS TO REPRODUCE:
1. Open WebInspector on any page
2. Go to the Network tab
3. Select a resource that has a request payload (e.g. JSON sent with the request)
4. Show the "Request" content under "Preview"
5. Fire another request on the page
 => "Response" content is suddenly shown

Example request:

    fetch("data.json?" + Math.random(), {
        method: "POST",
        // headers: {"Content-Type": "application/json"},
        body: `{"a":1,"b":2,"c":3,"d":4,"e":5,"f":6}`,
    });
Comment 1 Devin Rousso 2018-10-10 14:38:11 PDT
Created attachment 351986 [details]
Patch

This patch relies on changes from <https://webkit.org/b/189773>.  I will upload a different version if that bug takes a while to land.
Comment 2 Devin Rousso 2018-10-10 22:31:24 PDT
Created attachment 352017 [details]
Patch

Rebase
Comment 3 Joseph Pecoraro 2018-10-11 15:14:45 PDT
Comment on attachment 352017 [details]
Patch

Interesting! Does this fix when switching between resources? Currently when switching between resources it keeps popping back to "Response" instead of keeping it "Requests". That is probably separate though.
Comment 4 Devin Rousso 2018-10-11 19:02:53 PDT
(In reply to Joseph Pecoraro from comment #3)
> Interesting! Does this fix when switching between resources? Currently when
> switching between resources it keeps popping back to "Response" instead of
> keeping it "Requests". That is probably separate though.
Nope :(

Filed another bug: <https://webkit.org/b/190505>
Comment 5 WebKit Commit Bot 2018-10-11 19:30:25 PDT
Comment on attachment 352017 [details]
Patch

Clearing flags on attachment: 352017

Committed r237061: <https://trac.webkit.org/changeset/237061>
Comment 6 WebKit Commit Bot 2018-10-11 19:30:27 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-10-11 19:31:37 PDT
<rdar://problem/45214836>