Web Inspector: REGRESSION(r236853): Uncaught Exception: undefined is not an object (evaluating 'entry.resource')

[Devin Rousso]

-------
Inspected URL:        https://www.google.com/
Loading completed:    true
Frontend User Agent:  Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14) AppleWebKit/605.1.15 (KHTML, like Gecko)
Dispatch Source:      Protocol Event

Protocol Event:
{"method":"Page.frameNavigated","params":{"frame":{"id":"0.1","loaderId":"0.3","url":"https://www.google.com/","mimeType":"text/html","securityOrigin":"https://www.google.com"}}}

Uncaught Exceptions:
 - undefined is not an object (evaluating 'entry.resource') (at NetworkTableContentView.js:386:18)
    tablePopulateCell @ NetworkTableContentView.js:386:18
    reloadVisibleColumnCells @ Table.js:282:45
    _hideDetailView @ NetworkTableContentView.js:1259:45
    tableSelectionDidChange @ NetworkTableContentView.js:367:33
    _notifySelectionDidChange @ Table.js:1398:51
    _deselectAllAndSelect @ Table.js:1382:39
    deselectAll @ Table.js:373:35
    reset @ NetworkTableContentView.js:283:36
    _mainResourceDidChange @ NetworkTableContentView.js:1375:19
    dispatch @ Object.js:170:30
    dispatchEventToListeners @ Object.js:185:21
    _dispatchMainResourceDidChangeEvent @ Frame.js:483:38
    commitProvisionalLoad @ Frame.js:144:53
    frameDidNavigate @ NetworkManager.js:152:40
    frameNavigated @ PageObserver.js:42:43
    dispatchEvent @ InspectorBackend.js:298:42
    _dispatchEvent @ Connection.js:193:32
    dispatch @ Connection.js:71:32
    dispatch @ InspectorBackend.js:152:49
    dispatchNextQueuedMessageFromBackend @ MessageDispatcher.js:42:34

Additional Details:
    cause --> An uncaught exception was thrown while handling event: Page.frameNavigated
-------

* STEPS TO REPRODUCE
1. Inspect any page
2. Go to the Network tab
3. Select any entry to show the "Preview" details view
4. Refresh the page
 => Exception :(

[Matt Baker]

What is the relationship to https://bugs.webkit.org/show_bug.cgi?id=189705? Is this a regression caused by that change? If so, please indicate in the title (like we do) or add a comment.

[Devin Rousso]

(In reply to Matt Baker from comment #1)
> What is the relationship to https://bugs.webkit.org/show_bug.cgi?id=189705?
> Is this a regression caused by that change? If so, please indicate in the
> title (like we do) or add a comment.
I think it's a regression from, but I'm frankly not sure.  That's why I just added it as "See Also".  It most likely is, though, so I'll just assume so.

[Devin Rousso]

Created attachment 351988 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 351988 [details]
Patch

r=me Heh, yeah this makes sense to me.

[WebKit Commit Bot]

Comment on attachment 351988 [details]
Patch

Clearing flags on attachment: 351988

Committed r237019: <https://trac.webkit.org/changeset/237019>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/45175716>