Bug 190441 - DOMCache should dereference itself as soon as stopped
Summary: DOMCache should dereference itself as soon as stopped
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-10 14:07 PDT by youenn fablet
Modified: 2018-10-12 10:15 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.84 KB, patch)
2018-10-10 14:10 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (1.88 KB, patch)
2018-10-11 11:14 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-10-10 14:07:46 PDT 
Once stopped, it is no longer needed to keep a ref as the DOMCache is becoming a no-op.
Comment 1 youenn fablet 2018-10-10 14:10:23 PDT 
Created attachment 351983 [details]
Patch
Comment 2 Geoffrey Garen 2018-10-10 20:19:08 PDT 
Comment on attachment 351983 [details]
Patch

What prevents stop() from being called multiple times?
Comment 3 youenn fablet 2018-10-11 11:14:35 PDT 
Created attachment 352059 [details]
Patch
Comment 4 WebKit Commit Bot 2018-10-12 10:14:21 PDT 
Comment on attachment 352059 [details]
Patch

Clearing flags on attachment: 352059

Committed r237070: <https://trac.webkit.org/changeset/237070>
Comment 5 WebKit Commit Bot 2018-10-12 10:14:22 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-10-12 10:15:32 PDT 
<rdar://problem/45229381>