Bug 190439 - Web Inspector: Network: more aggressively snap timing blocks together
Summary: Web Inspector: Network: more aggressively snap timing blocks together
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-10 13:42 PDT by Devin Rousso
Modified: 2018-10-25 15:58 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.07 KB, patch)
2018-10-10 15:04 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (2.14 KB, patch)
2018-10-10 22:33 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2018-10-10 13:42:03 PDT
Right now, we don't do any snapping of timing phases, such that if one is close enough to the other we just join them.  We currently "rely" on pixel rounding to do this for us.  We should more aggressively snap these phase blocks together (e.g. if the difference is less than 2px just merge them).
Comment 1 Matt Baker 2018-10-10 13:48:10 PDT
(In reply to Devin Rousso from comment #0)
> Right now, we don't do any snapping of timing phases, such that if one is
> close enough to the other we just join them.  We currently "rely" on pixel
> rounding to do this for us.  We should more aggressively snap these phase
> blocks together (e.g. if the difference is less than 2px just merge them).

Nice. We do something similar when computing segments for rendering frame "bars".
Comment 2 Devin Rousso 2018-10-10 15:04:26 PDT
Created attachment 351990 [details]
Patch

This patch relies on changes from <https://webkit.org/b/189773>.  I will upload a different version if that bug takes a while to land.
Comment 3 Devin Rousso 2018-10-10 22:33:23 PDT
Created attachment 352018 [details]
Patch

Rebase
Comment 4 WebKit Commit Bot 2018-10-25 15:57:52 PDT
Comment on attachment 352018 [details]
Patch

Clearing flags on attachment: 352018

Committed r237430: <https://trac.webkit.org/changeset/237430>
Comment 5 WebKit Commit Bot 2018-10-25 15:57:54 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-10-25 15:58:26 PDT
<rdar://problem/45570193>