Bug 190432 - [iOS] Compare input string to UIKeyInput constants using string comparison instead of pointer comparison
Summary: [iOS] Compare input string to UIKeyInput constants using string comparison in...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
Keywords: InRadar
Depends on:
Blocks: 190571
  Show dependency treegraph
Reported: 2018-10-10 11:16 PDT by Daniel Bates
Modified: 2018-10-14 22:02 PDT (History)
2 users (show)

See Also:

Patch (2.60 KB, patch)
2018-10-10 11:18 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2018-10-10 11:16:21 PDT
Use string comparison when comparing against UIKeyInput constants instead of pointer comparison to make code less fragile should a developer create events using a copy of a UIKeyInput constant or re-creation of the value of a UIKeyInput constant.
Comment 1 Daniel Bates 2018-10-10 11:18:00 PDT
Created attachment 351973 [details]
Comment 2 Daniel Bates 2018-10-10 11:20:11 PDT
Comment on attachment 351973 [details]

Clearing flags on attachment: 351973

Committed r237007: <https://trac.webkit.org/changeset/237007>
Comment 3 Daniel Bates 2018-10-10 11:20:13 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-10-10 11:21:31 PDT