Bug 190430 - build-webkit --inspector-frontend shouldn't have a nonzero exit code
Summary: build-webkit --inspector-frontend shouldn't have a nonzero exit code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-10 10:47 PDT by Ross Kirsling
Modified: 2018-10-10 13:30 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.31 KB, patch)
2018-10-10 10:49 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2018-10-10 10:47:30 PDT 
build-webkit --inspector-frontend shouldn't have a nonzero exit code
Comment 1 Ross Kirsling 2018-10-10 10:49:54 PDT 
Created attachment 351970 [details]
Patch
Comment 2 Ross Kirsling 2018-10-10 10:52:27 PDT 
This has been busted forever, but I never took the time to investigate the cause until now. :P

Success output before patch:
> ** BUILD SUCCEEDED **
>
> xcodebuild: error: invalid option '--inspector-frontend'

Success output after patch:
> ** BUILD SUCCEEDED **
>
>
> ====================================================================
>  WebKit is now built (00m:05s).
>  To run Safari with this newly-built code, use the
>  "Tools/Scripts/run-safari" script.
> ====================================================================
Comment 3 BJ Burg 2018-10-10 11:01:01 PDT 
Comment on attachment 351970 [details]
Patch

rs=me
Comment 4 WebKit Commit Bot 2018-10-10 13:29:08 PDT 
Comment on attachment 351970 [details]
Patch

Clearing flags on attachment: 351970

Committed r237015: <https://trac.webkit.org/changeset/237015>
Comment 5 WebKit Commit Bot 2018-10-10 13:29:10 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-10-10 13:30:27 PDT 
<rdar://problem/45170865>