Bug 19043 - New window event for wxWebKit
: New window event for wxWebKit
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebKit wx
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To: Nobody
: Wx
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-05-14 00:48 PDT by Robin Dunn
Modified: 2009-04-15 15:47 PDT (History)
1 user (show)

See Also:


Attachments
patch for new window event (1.90 KB, patch)
2008-05-14 00:48 PDT, Robin Dunn
no flags Details | Formatted Diff | Diff
patch for new window event (1.90 KB, patch)
2008-05-14 00:49 PDT, Robin Dunn
kevino: review-
Details | Formatted Diff | Diff
Updated patch (1.84 KB, patch)
2009-04-15 14:38 PDT, Robin Dunn
kevino: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Dunn 2008-05-14 00:48:05 PDT
This patch adds sending of the new window event for wxWebKit
Comment 1 Robin Dunn 2008-05-14 00:48:57 PDT
Created attachment 21120 [details]
patch for new window event
Comment 2 Robin Dunn 2008-05-14 00:49:08 PDT
Created attachment 21121 [details]
patch for new window event
Comment 3 Kevin Ollivier 2008-05-28 13:43:09 PDT
Comment on attachment 21121 [details]
patch for new window event

This looks good except for one important detail. When we implement DecidePolicy events, we need to handle the case in which they are ignored. In this case, if possible, I think we should restructure the code so that if the wxWebViewNewWindowEvent is not handled, we will return PolicyIgnore rather than PolicyUse. We should also offer a "Cancel" event like with BeforeLoad to allow the app to block certain URLs and let WebCore know that they were blocked. 

Thanks for all your help! :)
Comment 4 Robin Dunn 2009-04-15 14:38:17 PDT
Created attachment 29516 [details]
Updated patch
Comment 5 Kevin Ollivier 2009-04-15 15:47:05 PDT
Landed in r42562, thanks!