Bug 19043 - New window event for wxWebKit
: New window event for wxWebKit
Status: RESOLVED FIXED
: WebKit
WebKit wx
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
: Wx
:
:
  Show dependency treegraph
 
Reported: 2008-05-14 00:48 PST by
Modified: 2009-04-15 15:47 PST (History)


Attachments
patch for new window event (1.90 KB, patch)
2008-05-14 00:48 PST, Robin Dunn
no flags Review Patch | Details | Formatted Diff | Diff
patch for new window event (1.90 KB, patch)
2008-05-14 00:49 PST, Robin Dunn
kevino: review-
Review Patch | Details | Formatted Diff | Diff
Updated patch (1.84 KB, patch)
2009-04-15 14:38 PST, Robin Dunn
kevino: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2008-05-14 00:48:05 PST
This patch adds sending of the new window event for wxWebKit
------- Comment #1 From 2008-05-14 00:48:57 PST -------
Created an attachment (id=21120) [details]
patch for new window event
------- Comment #2 From 2008-05-14 00:49:08 PST -------
Created an attachment (id=21121) [details]
patch for new window event
------- Comment #3 From 2008-05-28 13:43:09 PST -------
(From update of attachment 21121 [details])
This looks good except for one important detail. When we implement DecidePolicy events, we need to handle the case in which they are ignored. In this case, if possible, I think we should restructure the code so that if the wxWebViewNewWindowEvent is not handled, we will return PolicyIgnore rather than PolicyUse. We should also offer a "Cancel" event like with BeforeLoad to allow the app to block certain URLs and let WebCore know that they were blocked. 

Thanks for all your help! :)
------- Comment #4 From 2009-04-15 14:38:17 PST -------
Created an attachment (id=29516) [details]
Updated patch
------- Comment #5 From 2009-04-15 15:47:05 PST -------
Landed in r42562, thanks!