190429 – [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr

RESOLVED FIXED 190429

[JSC] Rename createXXX to tryCreateXXX if it can return RefPtr

https://bugs.webkit.org/show_bug.cgi?id=190429

Summary [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr

Yusuke Suzuki

Reported 2018-10-10 07:50:04 PDT

[JSC] Rename createXXX to tryCreateXXX if it can return RefPtr

Attachments
Patch (128.18 KB, patch) 2018-10-10 08:15 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (122.71 KB, patch) 2018-10-10 08:17 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (122.71 KB, patch) 2018-10-10 08:21 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (123.28 KB, patch) 2018-10-10 08:44 PDT, Yusuke Suzuki	saam: review+	Details Formatted Diff Diff
Patch (122.85 KB, patch) 2018-10-10 09:25 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (123.00 KB, patch) 2018-10-10 09:38 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (124.26 KB, patch) 2018-10-10 09:58 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Yusuke Suzuki

Comment 1 2018-10-10 08:15:58 PDT

Created attachment 351960 [details] Patch

Yusuke Suzuki

Comment 2 2018-10-10 08:17:24 PDT

Created attachment 351961 [details] Patch

Yusuke Suzuki

Comment 3 2018-10-10 08:21:32 PDT

Created attachment 351962 [details] Patch

Yusuke Suzuki

Comment 4 2018-10-10 08:44:47 PDT

Created attachment 351965 [details] Patch

Saam Barati

Comment 5 2018-10-10 08:50:36 PDT

Comment on attachment 351965 [details] Patch r=me if it builds

Yusuke Suzuki

Comment 6 2018-10-10 09:24:25 PDT

(In reply to Saam Barati from comment #5) > Comment on attachment 351965 [details] > Patch > > r=me if it builds Thank you!

Yusuke Suzuki

Comment 7 2018-10-10 09:25:12 PDT

Created attachment 351967 [details] Patch Patch for landing

Yusuke Suzuki

Comment 8 2018-10-10 09:38:47 PDT

Created attachment 351968 [details] Patch Patch for landing

Yusuke Suzuki

Comment 9 2018-10-10 09:58:49 PDT

Created attachment 351969 [details] Patch Patch for landing

Yusuke Suzuki

Comment 10 2018-10-10 11:29:50 PDT

Committed r237009: <https://trac.webkit.org/changeset/237009>

Radar WebKit Bug Importer

Comment 11 2018-10-10 11:30:37 PDT

<rdar://problem/45167096>

Dawei Fenton (:realdawei)

Comment 12 2018-10-10 13:35:07 PDT

(In reply to Yusuke Suzuki from comment #10) > Committed r237009: <https://trac.webkit.org/changeset/237009> Windows build appears to have been broken by this revision: sample output: https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/12371/steps/compile-webkit/logs/stdio WebCoreTestSupport.vcxproj -> C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\lib32\WebCoreTestSupport.lib WebKitSystemInterface.lib(MediaUI.obj) : warning LNK4099: PDB 'WebKitSystemInterface.pdb' was not found with 'WebKitSystemInterface.lib(MediaUI.obj)' or at 'C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\bin32\WebKitSystemInterface.pdb'; linking object as if no debug info [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Tools\TestWebKitAPI\TestWebCoreLib.vcxproj] WebKitSystemInterface.lib(WebKitSystemInterface.obj) : warning LNK4099: PDB 'WebKitSystemInterface.pdb' was not found with 'WebKitSystemInterface.lib(WebKitSystemInterface.obj)' or at 'C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\bin32\WebKitSystemInterface.pdb'; linking object as if no debug info [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Tools\TestWebKitAPI\TestWebCoreLib.vcxproj] WebKitSystemInterface.lib(WebKitSystemInterfacePrefix.obj) : warning LNK4099: PDB 'WebKitSystemInterface.pdb' was not found with 'WebKitSystemInterface.lib(WebKitSystemInterfacePrefix.obj)' or at 'C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\bin32\WebKitSystemInterface.pdb'; linking object as if no debug info [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Tools\TestWebKitAPI\TestWebCoreLib.vcxproj] WebKitSystemInterface.lib(SharedMediaUI.obj) : warning LNK4099: PDB 'WebKitSystemInterface.pdb' was not found with 'WebKitSystemInterface.lib(SharedMediaUI.obj)' or at 'C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\bin32\WebKitSystemInterface.pdb'; linking object as if no debug info [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Tools\TestWebKitAPI\TestWebCoreLib.vcxproj] WebDatabaseProvider.cpp Creating library C:/cygwin/home/buildbot/slave/win-release/build/WebKitBuild/Release/lib32/TestWebCoreLib.lib and object C:/cygwin/home/buildbot/slave/win-release/build/WebKitBuild/Release/lib32/TestWebCoreLib.exp WebCore.lib(MediaPlayerPrivateAVFoundationCF.obj) : error LNK2019: unresolved external symbol "public: class JSC::MarkedBlock & __thiscall JSC::HeapCell::markedBlock(void)const " (?markedBlock@HeapCell@JSC@@QBEAAVMarkedBlock@2@XZ) referenced in function "public: virtual class JSC::JSArrayBufferView * __thiscall JSC::GenericTypedArrayView<struct JSC::Uint16Adaptor>::wrap(class JSC::ExecState *,class JSC::JSGlobalObject *)" (?wrap@?$GenericTypedArrayView@UUint16Adaptor@JSC@@@JSC@@UAEPAVJSArrayBufferView@2@PAVExecState@2@PAVJSGlobalObject@2@@Z) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Tools\TestWebKitAPI\TestWebCoreLib.vcxproj] WebCore.lib(MediaPlayerPrivateAVFoundationCF.obj) : error LNK2019: unresolved external symbol "public: static class JSC::Heap * __cdecl JSC::Heap::heap(class JSC::HeapCell const *)" (?heap@Heap@JSC@@SAPAV12@PBVHeapCell@2@@Z) referenced in function "public: virtual class JSC::JSArrayBufferView * __thiscall JSC::GenericTypedArrayView<struct JSC::Uint16Adaptor>::wrap(class JSC::ExecState *,class JSC::JSGlobalObject *)" (?wrap@?$GenericTypedArrayView@UUint16Adaptor@JSC@@@JSC@@UAEPAVJSArrayBufferView@2@PAVExecState@2@PAVJSGlobalObject@2@@Z) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Tools\TestWebKitAPI\TestWebCoreLib.vcxproj] WebCore.lib(MediaPlayerPrivateAVFoundationCF.obj) : error LNK2019: unresolved external symbol "public: class JSC::VM * __thiscall JSC::Heap::vm(void)const " (?vm@Heap@JSC@@QBEPAVVM@2@XZ) referenced in function "void * __cdecl JSC::allocateCell<class JSC::JSGenericTypedArrayView<struct JSC::Uint16Adaptor> >(class JSC::Heap &,unsigned int)" (??$allocateCell@V?$JSGenericTypedArrayView@UUint16Adaptor@JSC@@@JSC@@@JSC@@YAPAXAAVHeap@0@I@Z) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Tools\TestWebKitAPI\TestWebCoreLib.vcxproj] C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\bin32\TestWebCoreLib.dll : fatal error LNK1120: 3 unresolved externals [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Tools\TestWebKitAPI\TestWebCoreLib.vcxproj] WebDatabaseProvider.cpp WebKitSystemInterface.lib(WebKitSystemInterface.obj) : warning LNK4099: PDB 'WebKitSystemInterface.pdb' was not found with 'WebKitSystemInterface.lib(WebKitSystemInterface.obj)' or at 'C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\bin32\WebKitSystemInterface.pdb'; linking object as if no debug info [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] WebKitSystemInterface.lib(MediaUI.obj) : warning LNK4099: PDB 'WebKitSystemInterface.pdb' was not found with 'WebKitSystemInterface.lib(MediaUI.obj)' or at 'C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\bin32\WebKitSystemInterface.pdb'; linking object as if no debug info [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] WebKitSystemInterface.lib(WebKitSystemInterfacePrefix.obj) : warning LNK4099: PDB 'WebKitSystemInterface.pdb' was not found with 'WebKitSystemInterface.lib(WebKitSystemInterfacePrefix.obj)' or at 'C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\bin32\WebKitSystemInterface.pdb'; linking object as if no debug info [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] WebKitSystemInterface.lib(SharedMediaUI.obj) : warning LNK4099: PDB 'WebKitSystemInterface.pdb' was not found with 'WebKitSystemInterface.lib(SharedMediaUI.obj)' or at 'C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\bin32\WebKitSystemInterface.pdb'; linking object as if no debug info [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] Creating library C:/cygwin/home/buildbot/slave/win-release/build/WebKitBuild/Release/lib32/WebKit.lib and object C:/cygwin/home/buildbot/slave/win-release/build/WebKitBuild/Release/lib32/WebKit.exp WebCore.lib(MediaPlayerPrivateAVFoundationCF.obj) : error LNK2019: unresolved external symbol "public: class JSC::MarkedBlock & __thiscall JSC::HeapCell::markedBlock(void)const " (?markedBlock@HeapCell@JSC@@QBEAAVMarkedBlock@2@XZ) referenced in function "public: virtual class JSC::JSArrayBufferView * __thiscall JSC::GenericTypedArrayView<struct JSC::Uint16Adaptor>::wrap(class JSC::ExecState *,class JSC::JSGlobalObject *)" (?wrap@?$GenericTypedArrayView@UUint16Adaptor@JSC@@@JSC@@UAEPAVJSArrayBufferView@2@PAVExecState@2@PAVJSGlobalObject@2@@Z) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] WebCore.lib(MediaPlayerPrivateAVFoundationCF.obj) : error LNK2019: unresolved external symbol "public: static class JSC::Heap * __cdecl JSC::Heap::heap(class JSC::HeapCell const *)" (?heap@Heap@JSC@@SAPAV12@PBVHeapCell@2@@Z) referenced in function "public: virtual class JSC::JSArrayBufferView * __thiscall JSC::GenericTypedArrayView<struct JSC::Uint16Adaptor>::wrap(class JSC::ExecState *,class JSC::JSGlobalObject *)" (?wrap@?$GenericTypedArrayView@UUint16Adaptor@JSC@@@JSC@@UAEPAVJSArrayBufferView@2@PAVExecState@2@PAVJSGlobalObject@2@@Z) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] WebCore.lib(MediaPlayerPrivateAVFoundationCF.obj) : error LNK2019: unresolved external symbol "public: class JSC::VM * __thiscall JSC::Heap::vm(void)const " (?vm@Heap@JSC@@QBEPAVVM@2@XZ) referenced in function "void * __cdecl JSC::allocateCell<class JSC::JSGenericTypedArrayView<struct JSC::Uint16Adaptor> >(class JSC::Heap &,unsigned int)" (??$allocateCell@V?$JSGenericTypedArrayView@UUint16Adaptor@JSC@@@JSC@@@JSC@@YAPAXAAVHeap@0@I@Z) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\bin32\WebKit.dll : fatal error LNK1120: 3 unresolved externals [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj]

Yusuke Suzuki

Comment 13 2018-10-10 14:23:48 PDT

Committed r237017: <https://trac.webkit.org/changeset/237017>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component New Bugs

Assignee

Yusuke Suzuki

Reported

2018-10-10 07:50 PDT

Modified

2018-10-10 14:23 PDT History

CC List

4 users Show

URL

Keywords InRadar

Depends on

Blocks