Bug 190426 - [JSC] [Armv7] stress/sampling-profiler-richards.js crashes
Summary: [JSC] [Armv7] stress/sampling-profiler-richards.js crashes
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-10 04:18 PDT by Guillaume Emont
Modified: 2018-11-02 04:44 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Guillaume Emont 2018-10-10 04:18:56 PDT
The test crashes on linux/armv7. When running the test manually, it only seems to crash with the sampling-profiler enabled.
Comment 1 Guillaume Emont 2018-10-10 04:39:32 PDT
Committed r237000: <https://trac.webkit.org/changeset/237000>
Comment 2 Guillaume Emont 2018-10-10 04:40:09 PDT
Reopening as the commit was only to skip the test.
Comment 3 Radar WebKit Bug Importer 2018-10-10 04:40:24 PDT
<rdar://problem/45157301>
Comment 4 Radar WebKit Bug Importer 2018-10-10 04:40:25 PDT
<rdar://problem/45157300>
Comment 5 Tadeu Zagallo 2018-11-02 03:26:12 PDT
FYI, I've put a patch up in https://bugs.webkit.org/show_bug.cgi?id=191184 to convert these to `skip if no $jitTests`, since they were also timing out on x86. I've removed the FIXME comments, since it should no longer be necessary to change the tests, only the runner. Let me know if you want me to keep the comments and I'll revert the changes.
Comment 6 Guillaume Emont 2018-11-02 04:42:52 PDT
(In reply to Tadeu Zagallo from comment #5)
> FYI, I've put a patch up in https://bugs.webkit.org/show_bug.cgi?id=191184
> to convert these to `skip if no $jitTests`, since they were also timing out
> on x86. I've removed the FIXME comments, since it should no longer be
> necessary to change the tests, only the runner. Let me know if you want me
> to keep the comments and I'll revert the changes.

I think we still need an explicit '@skip if $architecture == "arm"' for this test since I expect this crash to still be there once we reenable the JIT on arm (unless the bytecode changes accidentally fixed it).
Comment 7 Guillaume Emont 2018-11-02 04:44:59 PDT
(In reply to Guillaume Emont from comment #6)
> (In reply to Tadeu Zagallo from comment #5)
> > FYI, I've put a patch up in https://bugs.webkit.org/show_bug.cgi?id=191184
> > to convert these to `skip if no $jitTests`, since they were also timing out
> > on x86. I've removed the FIXME comments, since it should no longer be
> > necessary to change the tests, only the runner. Let me know if you want me
> > to keep the comments and I'll revert the changes.
> 
> I think we still need an explicit '@skip if $architecture == "arm"' for this
> test since I expect this crash to still be there once we reenable the JIT on
> arm (unless the bytecode changes accidentally fixed it).

FWIW your patch on Bug 191184 already does the right thing for this test.