Bug 190420 - Share more WKShareSheet code between macOS and iOS, and fix a few bugs
Summary: Share more WKShareSheet code between macOS and iOS, and fix a few bugs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-09 19:58 PDT by Tim Horton
Modified: 2018-10-10 12:06 PDT (History)
8 users (show)

See Also:


Attachments
Patch (36.57 KB, patch)
2018-10-09 19:58 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (36.55 KB, patch)
2018-10-09 20:21 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-sierra (2.34 MB, application/zip)
2018-10-09 21:30 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews116 for mac-sierra (3.04 MB, application/zip)
2018-10-09 22:09 PDT, EWS Watchlist
no flags Details
Patch (38.40 KB, patch)
2018-10-09 22:15 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (38.47 KB, patch)
2018-10-10 00:05 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (38.46 KB, patch)
2018-10-10 11:34 PDT, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2018-10-09 19:58:33 PDT
Share more WKShareSheet code between macOS and iOS, and fix a few bugs
Comment 1 Tim Horton 2018-10-09 19:58:53 PDT
Created attachment 351935 [details]
Patch
Comment 2 Tim Horton 2018-10-09 20:21:20 PDT
Created attachment 351936 [details]
Patch
Comment 3 EWS Watchlist 2018-10-09 21:30:09 PDT Comment hidden (obsolete)
Comment 4 EWS Watchlist 2018-10-09 21:30:11 PDT Comment hidden (obsolete)
Comment 5 EWS Watchlist 2018-10-09 22:09:26 PDT Comment hidden (obsolete)
Comment 6 EWS Watchlist 2018-10-09 22:09:28 PDT Comment hidden (obsolete)
Comment 7 Tim Horton 2018-10-09 22:15:02 PDT
Created attachment 351944 [details]
Patch
Comment 8 Tim Horton 2018-10-09 22:16:30 PDT
I forgot about legacy WebKit
Comment 9 Tim Horton 2018-10-10 00:05:13 PDT
And 32-bit.
Comment 10 Tim Horton 2018-10-10 00:05:30 PDT
Created attachment 351948 [details]
Patch
Comment 11 Simon Fraser (smfr) 2018-10-10 11:25:02 PDT
Comment on attachment 351948 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351948&action=review

> Source/WebKit/UIProcess/Cocoa/WKShareSheet.mm:79
> +        NSURL *url = (NSURL *)*data.url;

I think I prefer data.url.value() to avoid too many splats.
Comment 12 Tim Horton 2018-10-10 11:34:16 PDT
Created attachment 351976 [details]
Patch
Comment 13 WebKit Commit Bot 2018-10-10 12:05:11 PDT
Comment on attachment 351976 [details]
Patch

Clearing flags on attachment: 351976

Committed r237012: <https://trac.webkit.org/changeset/237012>
Comment 14 WebKit Commit Bot 2018-10-10 12:05:12 PDT
All reviewed patches have been landed.  Closing bug.
Comment 15 Radar WebKit Bug Importer 2018-10-10 12:06:28 PDT
<rdar://problem/45168515>