RESOLVED FIXED 190419
Performance dashboard should show added iterations due failed build requests. 
https://bugs.webkit.org/show_bug.cgi?id=190419
Summary Performance dashboard should show added iterations due failed build requests.
dewei_zhu
Reported 2018-10-09 17:33:59 PDT
Performance dashboard should show added iterations due failed build requests.
Attachments
Patch (3.65 KB, patch)
2018-10-09 17:38 PDT, dewei_zhu 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
dewei_zhu
Comment 1 2018-10-09 17:38:56 PDT
Created attachment 351929 [details] Patch
Ryosuke Niwa
Comment 2 2018-10-09 20:08:30 PDT
Comment on attachment 351929 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351929&action=review > Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js:374 > + this.content('status-summary').innerHTML = `${currentGroup.initialRepetitionCount()} requested, ${currentGroup.repetitionCount() - currentGroup.initialRepetitionCount()} added due to failures.`; Let's store values in local variables first so that the template literal looks nicer.
Ryosuke Niwa
Comment 3 2018-10-13 12:17:48 PDT
Have you landed this change??
Ryosuke Niwa
Comment 4 2018-10-13 12:18:28 PDT
Landed in https://trac.webkit.org/changeset/236997. Please don't forget to close bugs. You can use webkit-patch land to do that automatically.
dewei_zhu
Comment 5 2018-10-13 17:45:48 PDT
Thanks! I will use that script.
Radar WebKit Bug Importer
Comment 6 2018-10-14 20:16:26 PDT
<rdar://problem/45261523>
Note You need to log in before you can comment on or make changes to this bug.