Bug 190419 - Performance dashboard should show added iterations due failed build requests.
Summary: Performance dashboard should show added iterations due failed build requests.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-09 17:33 PDT by dewei_zhu
Modified: 2018-10-14 20:16 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.65 KB, patch)
2018-10-09 17:38 PDT, dewei_zhu 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description dewei_zhu 2018-10-09 17:33:59 PDT 
Performance dashboard should show added iterations due failed build requests.
Comment 1 dewei_zhu 2018-10-09 17:38:56 PDT 
Created attachment 351929 [details]
Patch
Comment 2 Ryosuke Niwa 2018-10-09 20:08:30 PDT 
Comment on attachment 351929 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351929&action=review

> Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js:374
> +            this.content('status-summary').innerHTML = `${currentGroup.initialRepetitionCount()} requested, ${currentGroup.repetitionCount() - currentGroup.initialRepetitionCount()} added due to failures.`;

Let's store values in local variables first so that the template literal looks nicer.
Comment 3 Ryosuke Niwa 2018-10-13 12:17:48 PDT 
Have you landed this change??
Comment 4 Ryosuke Niwa 2018-10-13 12:18:28 PDT 
Landed in https://trac.webkit.org/changeset/236997.

Please don't forget to close bugs. You can use webkit-patch land to do that automatically.
Comment 5 dewei_zhu 2018-10-13 17:45:48 PDT 
Thanks! I will use that script.
Comment 6 Radar WebKit Bug Importer 2018-10-14 20:16:26 PDT 
<rdar://problem/45261523>