Bug 19041 - [wx] Frames support
: [wx] Frames support
Status: RESOLVED FIXED
: WebKit
WebKit wx
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
: Wx
:
:
  Show dependency treegraph
 
Reported: 2008-05-13 20:57 PST by
Modified: 2009-09-03 14:22 PST (History)


Attachments
first pass at PltformScrollbar (9.47 KB, patch)
2008-05-14 00:43 PST, Robin Dunn
ddkilzer: review-
Review Patch | Details | Formatted Diff | Diff
wxWebFrame rename to enable us to work on next steps (27.02 KB, patch)
2008-05-16 23:24 PST, Kevin Ollivier
no flags Review Patch | Details | Formatted Diff | Diff
Revised wxWebFrame patch (32.99 KB, patch)
2008-08-06 17:02 PST, Kevin Watters
no flags Review Patch | Details | Formatted Diff | Diff
finishes wx port frames support (70.77 KB, patch)
2009-09-03 08:44 PST, Kevin Watters
no flags Review Patch | Details | Formatted Diff | Diff
finishes wx port frames support (revised) (66.05 KB, patch)
2009-09-03 12:15 PST, Kevin Watters
kevino: review+
kevino: commit‑queue-
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2008-05-13 20:57:29 PST
This is a bug for putting all the patches related to Frames support. I think in the end, it will require three major steps:

1. Rename wxWebFrame to wxWebBrowserShell, to allow us to create a wxWebFrame that is roughly analogous with WebFrame.

2. Implement wxWebFrame to encapsulate frame creation and load.

3. Implement support for PlatformScrollbar
------- Comment #1 From 2008-05-14 00:43:11 PST -------
Created an attachment (id=21119) [details]
first pass at PltformScrollbar

Here's a first try at PlatformScrollbar for you to play with.  Not sure if it's doing what it is supposed to yet, but it at least compiles.
------- Comment #2 From 2008-05-16 23:24:56 PST -------
Created an attachment (id=21210) [details]
wxWebFrame rename to enable us to work on next steps
------- Comment #3 From 2008-05-19 10:52:40 PST -------
(From update of attachment 21210 [details])
rs=me
------- Comment #4 From 2008-05-20 22:49:04 PST -------
wxWebFrame rename landed in r33957, thanks! :)
------- Comment #5 From 2008-05-28 07:12:22 PST -------
Can this bug be marked as RESOLVED/FIXED, or does Attachment #21119 [details] still need to be reviewed?
------- Comment #6 From 2008-05-28 11:23:53 PST -------
This still needs to be reviewed. I've finally got some extra time to work on clearing the backlog of patches, so hopefully we should have things worked out by tomorrow or so. (I would have done it yesterday, but the addition of SquirrelFish, and the recurrence of an old FontPlatformData crash which I thought we had fixed had me playing catchup for a while. ;-)
------- Comment #7 From 2008-06-08 13:35:50 PST -------
(From update of attachment 21210 [details])
Clearing the review flag on this already-landed patch.
------- Comment #8 From 2008-07-01 08:30:48 PST -------
(From update of attachment 21119 [details])
Thanks for the patch, Robin!

r- since this patch needs ChangeLog entries.  See this page for more details:

http://webkit.org/coding/contributing.html

Also note that it may have bit-rotted since the rename patch landed (and due to other renames in the WebKit source tree).  

Overall the style and formatting of the code in the patch looks good.  You might consider adding your own copyright statement to the modified files (or at least the brand new file, even though it's based on an existing file).

Please update the patch and resubmit!
------- Comment #9 From 2008-08-06 17:02:10 PST -------
Created an attachment (id=22689) [details]
Revised wxWebFrame patch

Revised version of the above patch implementing wxWebFrame, with ChangeLog entries.
------- Comment #10 From 2008-08-06 20:48:18 PST -------
(From update of attachment 22689 [details])
This looks good to me, and as discussed, we really can use the leak fix. :)
------- Comment #11 From 2008-08-06 20:52:38 PST -------
(From update of attachment 22689 [details])
Patch landed in r35620, thanks! :)
------- Comment #12 From 2009-09-03 08:44:16 PST -------
Created an attachment (id=38994) [details]
finishes wx port frames support
------- Comment #13 From 2009-09-03 12:15:27 PST -------
Created an attachment (id=39001) [details]
finishes wx port frames support (revised)
------- Comment #14 From 2009-09-03 14:22:18 PST -------
Landed in r48029, thanks! :)