Bug 19041 – [wx] Frames support

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit wx

[Kevin Ollivier]

This is a bug for putting all the patches related to Frames support. I think in the end, it will require three major steps:

1. Rename wxWebFrame to wxWebBrowserShell, to allow us to create a wxWebFrame that is roughly analogous with WebFrame.

2. Implement wxWebFrame to encapsulate frame creation and load.

3. Implement support for PlatformScrollbar

[Robin Dunn]

Created attachment 21119 [details]
first pass at PltformScrollbar

Here's a first try at PlatformScrollbar for you to play with.  Not sure if it's doing what it is supposed to yet, but it at least compiles.

[Kevin Ollivier]

Created attachment 21210 [details]
wxWebFrame rename to enable us to work on next steps

[Darin Adler]

Comment on attachment 21210 [details]
wxWebFrame rename to enable us to work on next steps

rs=me

[Kevin Ollivier]

wxWebFrame rename landed in r33957, thanks! :)

[David Kilzer (:ddkilzer)]

Can this bug be marked as RESOLVED/FIXED, or does Attachment #21119 [details] still need to be reviewed?

[Kevin Ollivier]

This still needs to be reviewed. I've finally got some extra time to work on clearing the backlog of patches, so hopefully we should have things worked out by tomorrow or so. (I would have done it yesterday, but the addition of SquirrelFish, and the recurrence of an old FontPlatformData crash which I thought we had fixed had me playing catchup for a while. ;-)

[Darin Adler]

Comment on attachment 21210 [details]
wxWebFrame rename to enable us to work on next steps

Clearing the review flag on this already-landed patch.

[David Kilzer (:ddkilzer)]

Comment on attachment 21119 [details]
first pass at PltformScrollbar

Thanks for the patch, Robin!

r- since this patch needs ChangeLog entries.  See this page for more details:

http://webkit.org/coding/contributing.html

Also note that it may have bit-rotted since the rename patch landed (and due to other renames in the WebKit source tree).  

Overall the style and formatting of the code in the patch looks good.  You might consider adding your own copyright statement to the modified files (or at least the brand new file, even though it's based on an existing file).

Please update the patch and resubmit!

[Kevin Watters]

Created attachment 22689 [details]
Revised wxWebFrame patch

Revised version of the above patch implementing wxWebFrame, with ChangeLog entries.

[Kevin Ollivier]

Comment on attachment 22689 [details]
Revised wxWebFrame patch

This looks good to me, and as discussed, we really can use the leak fix. :)

[Kevin Ollivier]

Comment on attachment 22689 [details]
Revised wxWebFrame patch

Patch landed in r35620, thanks! :)

[Kevin Watters]

Created attachment 38994 [details]
finishes wx port frames support

[Kevin Watters]

Created attachment 39001 [details]
finishes wx port frames support (revised)

[Kevin Ollivier]

Landed in r48029, thanks! :)