Bug 190409 - [WPE][GTK] Complex text crashes with harfbuzz 1.8.8
Summary: [WPE][GTK] Complex text crashes with harfbuzz 1.8.8
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-09 13:24 PDT by Michael Catanzaro
Modified: 2018-10-09 14:59 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.18 KB, patch)
2018-10-09 13:27 PDT, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2018-10-09 13:24:15 PDT 
From https://gitlab.gnome.org/GNOME/evolution/issues/157

We discovered that harfbuzz 1.8.8 breaks WebKit by changing the ownership semantics of hb_icu_get_unicode_funcs() from (transfer full) to (transfer none). Our code was actually expecting (transfer none), so it's not immediately clear to me why it's crashing now, but doesn't matter as per Behdad:

"Please just remove that line of code.  hb-buffer comes up prepared with unicode-funcs these days (has had, for at least five years).  Just removing that line completely results in better output."

This should be covered by all our complex text tests if the bots were upgraded to the newer harfbuzz.
Comment 1 Michael Catanzaro 2018-10-09 13:27:56 PDT 
Created attachment 351905 [details]
Patch
Comment 2 WebKit Commit Bot 2018-10-09 14:59:20 PDT 
Comment on attachment 351905 [details]
Patch

Clearing flags on attachment: 351905

Committed r236985: <https://trac.webkit.org/changeset/236985>
Comment 3 WebKit Commit Bot 2018-10-09 14:59:21 PDT 
All reviewed patches have been landed.  Closing bug.