RESOLVED FIXED 190408
Anchor target should be ignored on activation when the download attribute is set 
https://bugs.webkit.org/show_bug.cgi?id=190408
Summary Anchor target should be ignored on activation when the download attribute is set
Chris Dumez
Reported 2018-10-09 12:27:14 PDT
Anchor target should be ignored on activation when the download attribute is set: - https://html.spec.whatwg.org/#the-a-element:downloading-hyperlinks-2 When the download attribute is set, we should use the "download the hyperlink" algorithm [1] instead of the "follow the hyperlink" [2] algorithm. Note that the "download the hyperlink" triggers a download and ignores the target attribute entirely. This is important as an anchor element with target=_blank and the download attribute set may fail because of Safari's popup blocker if we do not disregard the anchor target. [1] https://html.spec.whatwg.org/#downloading-hyperlinks [2] https://html.spec.whatwg.org/#following-hyperlinks-2
Attachments
Patch (17.98 KB, patch)
2018-10-09 12:35 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (22.46 KB, patch)
2018-10-09 13:07 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (23.95 KB, patch)
2018-10-09 14:14 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2018-10-09 12:35:02 PDT
Created attachment 351902 [details] Patch
Chris Dumez
Comment 2 2018-10-09 13:07:56 PDT
Created attachment 351903 [details] Patch
Chris Dumez
Comment 3 2018-10-09 14:14:52 PDT
Created attachment 351916 [details] Patch
Geoffrey Garen
Comment 4 2018-10-09 15:54:06 PDT
Comment on attachment 351916 [details] Patch r=me
WebKit Commit Bot
Comment 5 2018-10-09 16:21:25 PDT
Comment on attachment 351916 [details] Patch Clearing flags on attachment: 351916 Committed r236987: <https://trac.webkit.org/changeset/236987>
WebKit Commit Bot
Comment 6 2018-10-09 16:21:27 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-10-09 16:22:29 PDT
<rdar://problem/45145107>
Note You need to log in before you can comment on or make changes to this bug.