Bug 190403 - Web Inspector: REGRESSION: fix canvas test failures after r236952 and r236954
Summary: Web Inspector: REGRESSION: fix canvas test failures after r236952 and r236954
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: 190305 190325
Blocks:
  Show dependency tree / graph
 
Reported: 2018-10-09 10:30 PDT by Devin Rousso
Modified: 2018-10-09 12:07 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.89 KB, patch)
2018-10-09 10:34 PDT, Devin Rousso 		joepeck: review+
Details | Formatted Diff | Diff
Patch (5.89 KB, patch)
2018-10-09 10:44 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2018-10-09 10:30:08 PDT 
Related bugs:
 - <https://webkit.org/b/190305>
 - <https://webkit.org/b/190325>
Comment 1 Devin Rousso 2018-10-09 10:34:05 PDT 
Created attachment 351888 [details]
Patch
Comment 2 Joseph Pecoraro 2018-10-09 10:40:04 PDT 
Comment on attachment 351888 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351888&action=review

r=me

> LayoutTests/inspector/canvas/resources/shaderProgram-utilities.js:78
> +                // This can't use `awaitEvent` since the promise resolution happens on the next tick.sss

Whats up with the "tick.sss" at the end of this sentence? Just a typo?
Comment 3 Devin Rousso 2018-10-09 10:43:28 PDT 
Comment on attachment 351888 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351888&action=review

>> LayoutTests/inspector/canvas/resources/shaderProgram-utilities.js:78
>> +                // This can't use `awaitEvent` since the promise resolution happens on the next tick.sss
> 
> Whats up with the "tick.sss" at the end of this sentence? Just a typo?

That was my attempt at Cmd+S on the bus 😅
Comment 4 Devin Rousso 2018-10-09 10:44:01 PDT 
Created attachment 351893 [details]
Patch
Comment 5 WebKit Commit Bot 2018-10-09 12:04:25 PDT 
Comment on attachment 351893 [details]
Patch

Clearing flags on attachment: 351893

Committed r236972: <https://trac.webkit.org/changeset/236972>
Comment 6 WebKit Commit Bot 2018-10-09 12:04:27 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-10-09 12:07:35 PDT 
<rdar://problem/45134558>