Bug 190398 – [WPE] Explicitly link against gmodule where used

• Status: RESOLVED
• Resolution: FIXED
• Component: WPE WebKit

[Claudio Saavedra]

[WPE] Explicitly link against gmodule where used

[Claudio Saavedra]

Created attachment 351879 [details]
Patch

[Claudio Saavedra]

I ran into linking issues downstream because gmodule was not being pulled in, so let's add this. Not sure if it's needed for GTK+, but maybe yes.

[Adrian Perez]

(In reply to Claudio Saavedra from comment #2)
> I ran into linking issues downstream because gmodule was not being pulled
> in, so let's add this. Not sure if it's needed for GTK+, but maybe yes.

I think the linking error is noticeable more easily in the WPE port because
GModule is used in JSC to load “libWPEInspectorResources.so”, which gets
built first, but then it's used also in WebKit's “ModuleGlib.cpp” and
“InjectedBundleGlib.cpp” so both ports en up using it. It could be that
in the case of the GTK+ port some of the additional libraries used by 
the sources in the “WebKit/” subdir also use GModule, and that's why we
don't see linker errors there.

At any rate, the correct thing to do is explicitly adding the GModule
flags obtained from pkg-config to the targets which use them, so let's
land this (informal r+ here!)

[Adrian Perez]

FWIW, the GTK+ port already has GModule in “Source/WebCore/PlatformGTK.cmake”,
so no changes should be needed for the GTK+ port.

[WebKit Commit Bot]

Comment on attachment 351879 [details]
Patch

Clearing flags on attachment: 351879

Committed r236975: <https://trac.webkit.org/changeset/236975>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.