Bug 190394 - r236735 has some dead ASSERTs that need to be moved
Summary: r236735 has some dead ASSERTs that need to be moved
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alicia Boya García
Keywords: InRadar
Depends on: 190143
  Show dependency treegraph
Reported: 2018-10-08 23:33 PDT by Xabier Rodríguez Calvar
Modified: 2018-10-09 10:41 PDT (History)
6 users (show)

See Also:

Patch (2.13 KB, patch)
2018-10-09 00:08 PDT, Alicia Boya García
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xabier Rodríguez Calvar 2018-10-08 23:33:16 PDT
+++ This bug was initially created as a clone of Bug #190143 +++

The MP4 file used in this URL does not contain a stss (Sync Sample
Box). In consequence, in acordance with the ISO BMFF spec, all samples
are assumed to be sync frames... But in this case that is not true,
it's just that the file is wrong (e.g. created with a buggy muxer).


The way it works in other browsers is because instead of trusting the
MP4 stss table, they rely on parsing the h264 frames. We can do that
too, using h264parse.
Comment 1 Alicia Boya García 2018-10-09 00:08:27 PDT
Created attachment 351867 [details]
Comment 2 WebKit Commit Bot 2018-10-09 10:40:10 PDT
Comment on attachment 351867 [details]

Clearing flags on attachment: 351867

Committed r236967: <https://trac.webkit.org/changeset/236967>
Comment 3 WebKit Commit Bot 2018-10-09 10:40:11 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-10-09 10:41:26 PDT