Bug 190393 - ManifestGenerator shouldn't need more than 1GB of memory or run for 30 seconds
Summary: ManifestGenerator shouldn't need more than 1GB of memory or run for 30 seconds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Perf Dashboard (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-08 22:50 PDT by Ryosuke Niwa
Modified: 2018-10-09 20:20 PDT (History)
8 users (show)

See Also:


Attachments
Improves the generator (11.74 KB, patch)
2018-10-08 23:27 PDT, Ryosuke Niwa
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2018-10-08 22:50:23 PDT
In the internal instance of perf dashboard, manifest generation is taking 30s+ and requiring more than 1GB of RAM.
Improve ManifestGenerator to reduce the runtime & memory usage required.
Comment 1 Ryosuke Niwa 2018-10-08 23:27:09 PDT
Created attachment 351863 [details]
Improves the generator
Comment 2 Ryosuke Niwa 2018-10-08 23:28:35 PDT
Together with https://trac.webkit.org/changeset/236956, this patch should dramatically reduce the memory & CPU pressure on the internal perf dashboard.
Comment 3 dewei_zhu 2018-10-09 17:36:39 PDT
Looks good to me.
Comment 4 Ryosuke Niwa 2018-10-09 20:15:41 PDT
Committed r236996: <https://trac.webkit.org/changeset/236996>
Comment 5 Radar WebKit Bug Importer 2018-10-09 20:20:22 PDT
<rdar://problem/45149799>