RESOLVED FIXED 190382
/api/report takes 15+ minutes submitting some test results 
https://bugs.webkit.org/show_bug.cgi?id=190382
Summary /api/report takes 15+ minutes submitting some test results
Ryosuke Niwa
Reported 2018-10-08 16:44:29 PDT
When submitting the result of an internal memory test, /api/report can take up to 15 minutes to process the request. Speed this up in common cases where all tests and metrics had already been created.
Attachments
Fixes the bug for common cases (8.85 KB, patch)
2018-10-08 16:57 PDT, Ryosuke Niwa 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2018-10-08 16:57:19 PDT
Created attachment 351834 [details] Fixes the bug for common cases
dewei_zhu
Comment 2 2018-10-08 17:13:27 PDT
Comment on attachment 351834 [details] Fixes the bug for common cases View in context: https://bugs.webkit.org/attachment.cgi?id=351834&action=review > Websites/perf.webkit.org/public/include/report-processor.php:211 > + $this->gn = 0; Is this used anywhere? > Websites/perf.webkit.org/public/include/report-processor.php:250 > + $metric_id = $metrics ? $metrics[''] : NULL; Could you explain why we want to use $metrics[''] here?
dewei_zhu
Comment 3 2018-10-08 17:43:06 PDT
Comment on attachment 351834 [details] Fixes the bug for common cases View in context: https://bugs.webkit.org/attachment.cgi?id=351834&action=review >> Websites/perf.webkit.org/public/include/report-processor.php:211 >> + $this->gn = 0; > > Is this used anywhere? Ryosuke said this was for debugging purpose and will remove from the final change. >> Websites/perf.webkit.org/public/include/report-processor.php:250 >> + $metric_id = $metrics ? $metrics[''] : NULL; > > Could you explain why we want to use $metrics[''] here? Talked in person and this is correct behavior.
dewei_zhu
Comment 4 2018-10-08 17:43:22 PDT
Looks good to me.
Alexey Proskuryakov
Comment 5 2018-10-08 18:39:20 PDT
Comment on attachment 351834 [details] Fixes the bug for common cases rs=me
Ryosuke Niwa
Comment 6 2018-10-08 19:17:44 PDT
Committed r236956: <https://trac.webkit.org/changeset/236956>
Radar WebKit Bug Importer
Comment 7 2018-10-08 19:18:26 PDT
<rdar://problem/45114055>
Note You need to log in before you can comment on or make changes to this bug.