When submitting the result of an internal memory test, /api/report can take up to 15 minutes to process the request. Speed this up in common cases where all tests and metrics had already been created.
Created attachment 351834 [details] Fixes the bug for common cases
Comment on attachment 351834 [details] Fixes the bug for common cases View in context: https://bugs.webkit.org/attachment.cgi?id=351834&action=review > Websites/perf.webkit.org/public/include/report-processor.php:211 > + $this->gn = 0; Is this used anywhere? > Websites/perf.webkit.org/public/include/report-processor.php:250 > + $metric_id = $metrics ? $metrics[''] : NULL; Could you explain why we want to use $metrics[''] here?
Comment on attachment 351834 [details] Fixes the bug for common cases View in context: https://bugs.webkit.org/attachment.cgi?id=351834&action=review >> Websites/perf.webkit.org/public/include/report-processor.php:211 >> + $this->gn = 0; > > Is this used anywhere? Ryosuke said this was for debugging purpose and will remove from the final change. >> Websites/perf.webkit.org/public/include/report-processor.php:250 >> + $metric_id = $metrics ? $metrics[''] : NULL; > > Could you explain why we want to use $metrics[''] here? Talked in person and this is correct behavior.
Looks good to me.
Comment on attachment 351834 [details] Fixes the bug for common cases rs=me
Committed r236956: <https://trac.webkit.org/changeset/236956>
<rdar://problem/45114055>