Bug 190371 - [iOS] Ignore some deprecated declarations
Summary: [iOS] Ignore some deprecated declarations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-08 14:19 PDT by Daniel Bates
Modified: 2018-10-09 14:30 PDT (History)
3 users (show)

See Also:


Attachments
Patch (7.92 KB, patch)
2018-10-08 14:20 PDT, Daniel Bates
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2018-10-08 14:19:14 PDT
Ignore some deprecated declarations when building with a newer iOS SDK.
Comment 1 Daniel Bates 2018-10-08 14:20:52 PDT
Created attachment 351814 [details]
Patch
Comment 2 mitz 2018-10-08 15:18:44 PDT
Comment on attachment 351814 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351814&action=review

rs=me

> Source/WebKit/UIProcess/ios/WKActionSheet.mm:55
> +#pragma clang diagnostic push
> +#pragma clang diagnostic ignored "-Wdeprecated-declarations"

Please use the ALLOW_DEPRECATED_DECLARATIONS_{BEGIN,END} macros instead.
Comment 3 Daniel Bates 2018-10-09 14:29:40 PDT
Committed r236981: <https://trac.webkit.org/changeset/236981>
Comment 4 Radar WebKit Bug Importer 2018-10-09 14:30:32 PDT
<rdar://problem/45140555>