Use Full Screen consistently in localizable strings.
rdar://problem/43882333
Created attachment 351797 [details] Patch
Comment on attachment 351797 [details] Patch Attachment 351797 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9494041 New failing tests: css3/filters/backdrop/add-remove-add-backdrop-filter.html
Created attachment 351809 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 351797 [details] Patch Rejecting attachment 351797 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 351797, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=351797&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=190363&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 351797 from bug 190363. Fetching: https://bugs.webkit.org/attachment.cgi?id=351797 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Jon Lee']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 5 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. can't find file to patch at input line 5 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |Index: Source/WebCore/English.lproj/Localizable.strings |index dc35d93109c71b38793d7dddfab0612ebe1f1719..7b3ad46c492a0bd3b8ec9cc2300a5d6319187971 100644 |--- Source/WebCore/English.lproj/Localizable.strings (revision 0) |+++ Source/WebCore/English.lproj/Localizable.strings (working copy) -------------------------- No file to patch. Skipping patch. 6 out of 6 hunks ignored patching file Source/WebCore/platform/LocalizedStrings.cpp Hunk #2 succeeded at 784 (offset 5 lines). patching file Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Jon Lee']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/10026410
Created attachment 355652 [details] Patch for landing.
Comment on attachment 355652 [details] Patch for landing. Clearing flags on attachment: 355652 Committed r238503: <https://trac.webkit.org/changeset/238503>