Bug 190362 – Web Inspector: REGRESSION: selection in network table is lost when new entries are added

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

* STEPS TO REPRODUCE:
1. Inspect <https://devstreaming-cdn.apple.com/videos/streaming/examples/img_bipbop_adv_example_fmp4/master.m3u8>
2. Open the Network tab
3. Refresh the page
4. Select an entry in the network table
5. Play the video (should add another entry to the end of the table)
 => Selection is lost

From what I can tell, it seems that this is caused by the fact that the `WI.Table` in the `WI.NetworkTableContentView` has its `layout()` call _after_ it's "owner" `WI.NetworkTableContentView`.  Since the manager of the selected row is the `WI.NetworkTableContentView`, the `WI.Table` has no idea about what it is or how to restore it.  As such, when the `WI.Table` calls `layout()` the selection styling is lost, even though `WI.NetworkTableContentView` still has a reference to the selected row.

Possibly a regression from r236853 <https://webkit.org/b/189705>.

[Devin Rousso]

Created attachment 351975 [details]
Patch

[Matt Baker]

Comment on attachment 351975 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351975&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/Table.js:241
> +        this._selectedRowIndex = NaN;

Oops, good catch!

[WebKit Commit Bot]

Comment on attachment 351975 [details]
Patch

Clearing flags on attachment: 351975

Committed r237016: <https://trac.webkit.org/changeset/237016>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/45171654>