Bug 190359 – Enable external playback for video in element fullscreen.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jeremy Jones]

Enable external playback for video in element fullscreen.

[Jeremy Jones]

Created attachment 351791 [details]
Patch

[Jeremy Jones]

rdar://problem/42560085

[Jeremy Jones]

Created attachment 351802 [details]
Patch

[Jeremy Jones]

Created attachment 351804 [details]
Patch

[Jeremy Jones]

Created attachment 351808 [details]
Patch

[Jeremy Jones]

Created attachment 353716 [details]
Patch

[Jer Noble]

Comment on attachment 353716 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353716&action=review

r=me with nits

> Source/WebCore/html/HTMLMediaElement.h:737
> +    bool mediaPlayerVideoFullscreenStandby() const final { return m_videoFullscreenStandby; }

This is a verb that wants to be a noun. Could we do mediaPlayerIsVideoFullscreenStandby()? (and in all the related declarations)

> Source/WebCore/platform/graphics/MediaPlayer.cpp:724
> +void MediaPlayer::setVideoFullscreenStandby(bool isStandby)
> +{
> +    m_private->setVideoFullscreenStandby(isStandby);
> +}

We pass isStandby in here but never use it. Could we rename this "videoFullscreenStandbyChanged()"?

[Jeremy Jones]

Comment on attachment 353716 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353716&action=review

>> Source/WebCore/html/HTMLMediaElement.h:737
>> +    bool mediaPlayerVideoFullscreenStandby() const final { return m_videoFullscreenStandby; }
> 
> This is a verb that wants to be a noun. Could we do mediaPlayerIsVideoFullscreenStandby()? (and in all the related declarations)

Done.

>> Source/WebCore/platform/graphics/MediaPlayer.cpp:724
>> +}
> 
> We pass isStandby in here but never use it. Could we rename this "videoFullscreenStandbyChanged()"?

Done.

[Jeremy Jones]

Created attachment 353882 [details]
Patch For Landing

[WebKit Commit Bot]

Comment on attachment 353882 [details]
Patch For Landing

Clearing flags on attachment: 353882

Committed r238327: <https://trac.webkit.org/changeset/238327>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.