Enable external playback for video in element fullscreen.
Created attachment 351791 [details] Patch
rdar://problem/42560085
Created attachment 351802 [details] Patch
Created attachment 351804 [details] Patch
Created attachment 351808 [details] Patch
Created attachment 353716 [details] Patch
Comment on attachment 353716 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353716&action=review r=me with nits > Source/WebCore/html/HTMLMediaElement.h:737 > + bool mediaPlayerVideoFullscreenStandby() const final { return m_videoFullscreenStandby; } This is a verb that wants to be a noun. Could we do mediaPlayerIsVideoFullscreenStandby()? (and in all the related declarations) > Source/WebCore/platform/graphics/MediaPlayer.cpp:724 > +void MediaPlayer::setVideoFullscreenStandby(bool isStandby) > +{ > + m_private->setVideoFullscreenStandby(isStandby); > +} We pass isStandby in here but never use it. Could we rename this "videoFullscreenStandbyChanged()"?
Comment on attachment 353716 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353716&action=review >> Source/WebCore/html/HTMLMediaElement.h:737 >> + bool mediaPlayerVideoFullscreenStandby() const final { return m_videoFullscreenStandby; } > > This is a verb that wants to be a noun. Could we do mediaPlayerIsVideoFullscreenStandby()? (and in all the related declarations) Done. >> Source/WebCore/platform/graphics/MediaPlayer.cpp:724 >> +} > > We pass isStandby in here but never use it. Could we rename this "videoFullscreenStandbyChanged()"? Done.
Created attachment 353882 [details] Patch For Landing
Comment on attachment 353882 [details] Patch For Landing Clearing flags on attachment: 353882 Committed r238327: <https://trac.webkit.org/changeset/238327>
All reviewed patches have been landed. Closing bug.