Bug 190347 – Move SystemFontDatabase to a file of its own

• Status: RESOLVED
• Resolution: FIXED
• Component: Text

[Antti Koivisto]

From FontDescriptionCocoa

[Antti Koivisto]

Created attachment 351772 [details]
patch

[Chris Dumez]

Comment on attachment 351772 [details]
patch

rs=me

[WebKit Commit Bot]

Comment on attachment 351772 [details]
patch

Rejecting attachment 351772 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 351772, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=351772&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=190347&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 351772 from bug 190347.
Fetching: https://bugs.webkit.org/attachment.cgi?id=351772
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Chris Dumez']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 7 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/SourcesCocoa.txt
patching file Source/WebCore/WebCore.xcodeproj/project.pbxproj
Hunk #1 FAILED at 4811.
Hunk #2 FAILED at 14548.
Hunk #3 succeeded at 24028 (offset 5 lines).
Hunk #4 succeeded at 27498 (offset 6 lines).
2 out of 4 hunks FAILED -- saving rejects to file Source/WebCore/WebCore.xcodeproj/project.pbxproj.rej
patching file Source/WebCore/platform/graphics/cocoa/FontDescriptionCocoa.cpp
patching file Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp
patching file Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.h
patching file Source/WebCore/platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp
Hunk #1 FAILED at 42.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Chris Dumez']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/9491130

[Antti Koivisto]

Created attachment 351780 [details]
patch

[Antti Koivisto]

Created attachment 351783 [details]
patch

[Antti Koivisto]

Created attachment 351784 [details]
patch

[Antti Koivisto]

Created attachment 351788 [details]
patch

[Antti Koivisto]

Created attachment 351790 [details]
patch

[Antti Koivisto]

Created attachment 351796 [details]
patch

[WebKit Commit Bot]

Comment on attachment 351796 [details]
patch

Rejecting attachment 351796 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 351796, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog is not at the top of the file.

Full output: https://webkit-queues.webkit.org/results/9493359

[Antti Koivisto]

Created attachment 351807 [details]
patch

[WebKit Commit Bot]

Comment on attachment 351807 [details]
patch

Clearing flags on attachment: 351807

Committed r236938: <https://trac.webkit.org/changeset/236938>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/45102888>