Bug 190347 - Move SystemFontDatabase to a file of its own
Summary: Move SystemFontDatabase to a file of its own
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-08 05:38 PDT by Antti Koivisto
Modified: 2018-10-08 13:38 PDT (History)
7 users (show)

See Also:


Attachments
patch (36.49 KB, patch)
2018-10-08 05:44 PDT, Antti Koivisto
cdumez: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
patch (35.95 KB, patch)
2018-10-08 09:53 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (35.99 KB, patch)
2018-10-08 10:03 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (35.93 KB, patch)
2018-10-08 10:06 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (39.47 KB, patch)
2018-10-08 10:22 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (39.66 KB, patch)
2018-10-08 10:47 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (39.67 KB, patch)
2018-10-08 11:30 PDT, Antti Koivisto
commit-queue: commit-queue-
Details | Formatted Diff | Diff
patch (39.57 KB, patch)
2018-10-08 12:53 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2018-10-08 05:38:01 PDT
From FontDescriptionCocoa
Comment 1 Antti Koivisto 2018-10-08 05:44:02 PDT
Created attachment 351772 [details]
patch
Comment 2 Chris Dumez 2018-10-08 09:12:06 PDT
Comment on attachment 351772 [details]
patch

rs=me
Comment 3 WebKit Commit Bot 2018-10-08 09:16:28 PDT
Comment on attachment 351772 [details]
patch

Rejecting attachment 351772 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 351772, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=351772&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=190347&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 351772 from bug 190347.
Fetching: https://bugs.webkit.org/attachment.cgi?id=351772
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Chris Dumez']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 7 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/SourcesCocoa.txt
patching file Source/WebCore/WebCore.xcodeproj/project.pbxproj
Hunk #1 FAILED at 4811.
Hunk #2 FAILED at 14548.
Hunk #3 succeeded at 24028 (offset 5 lines).
Hunk #4 succeeded at 27498 (offset 6 lines).
2 out of 4 hunks FAILED -- saving rejects to file Source/WebCore/WebCore.xcodeproj/project.pbxproj.rej
patching file Source/WebCore/platform/graphics/cocoa/FontDescriptionCocoa.cpp
patching file Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp
patching file Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.h
patching file Source/WebCore/platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp
Hunk #1 FAILED at 42.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Chris Dumez']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/9491130
Comment 4 Antti Koivisto 2018-10-08 09:53:58 PDT
Created attachment 351780 [details]
patch
Comment 5 Antti Koivisto 2018-10-08 10:03:28 PDT
Created attachment 351783 [details]
patch
Comment 6 Antti Koivisto 2018-10-08 10:06:25 PDT
Created attachment 351784 [details]
patch
Comment 7 Antti Koivisto 2018-10-08 10:22:18 PDT
Created attachment 351788 [details]
patch
Comment 8 Antti Koivisto 2018-10-08 10:47:38 PDT
Created attachment 351790 [details]
patch
Comment 9 Antti Koivisto 2018-10-08 11:30:44 PDT
Created attachment 351796 [details]
patch
Comment 10 WebKit Commit Bot 2018-10-08 12:22:34 PDT
Comment on attachment 351796 [details]
patch

Rejecting attachment 351796 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 351796, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog is not at the top of the file.

Full output: https://webkit-queues.webkit.org/results/9493359
Comment 11 Antti Koivisto 2018-10-08 12:53:28 PDT
Created attachment 351807 [details]
patch
Comment 12 WebKit Commit Bot 2018-10-08 13:37:34 PDT
Comment on attachment 351807 [details]
patch

Clearing flags on attachment: 351807

Committed r236938: <https://trac.webkit.org/changeset/236938>
Comment 13 WebKit Commit Bot 2018-10-08 13:37:35 PDT
All reviewed patches have been landed.  Closing bug.
Comment 14 Radar WebKit Bug Importer 2018-10-08 13:38:22 PDT
<rdar://problem/45102888>