Bug 190342 - [Cocoa] [WK2] Add support for text alignment and text lists in font attributes
Summary: [Cocoa] [WK2] Add support for text alignment and text lists in font attributes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-07 15:45 PDT by Wenson Hsieh
Modified: 2018-10-08 18:52 PDT (History)
8 users (show)

See Also:

Attachments
First pass (39.83 KB, patch)
2018-10-07 16:15 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Fix OpenSource iOS, macOS 10.12 builds (39.71 KB, patch)
2018-10-07 16:31 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Fix OpenSource iOS build (41.77 KB, patch)
2018-10-07 16:45 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Fix OpenSource iOS build (2) (39.76 KB, patch)
2018-10-07 16:54 PDT, Wenson Hsieh 		ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-sierra (2.48 MB, application/zip)
2018-10-07 17:42 PDT, EWS Watchlist 		no flags Details
Patch (47.88 KB, patch)
2018-10-07 19:56 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Rebase on trunk (47.72 KB, patch)
2018-10-08 18:30 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-10-07 15:45:04 PDT 
<rdar://problem/44767118>
Comment 1 Wenson Hsieh 2018-10-07 16:15:49 PDT 
Created attachment 351749 [details]
First pass
Comment 2 Wenson Hsieh 2018-10-07 16:31:11 PDT 
Created attachment 351750 [details]
Fix OpenSource iOS, macOS 10.12 builds
Comment 3 Wenson Hsieh 2018-10-07 16:45:19 PDT 
Created attachment 351752 [details]
Fix OpenSource iOS build
Comment 4 Wenson Hsieh 2018-10-07 16:54:46 PDT 
Created attachment 351753 [details]
Fix OpenSource iOS build (2)
Comment 5 EWS Watchlist 2018-10-07 17:42:33 PDT Comment hidden (obsolete)
Comment 6 EWS Watchlist 2018-10-07 17:42:34 PDT Comment hidden (obsolete)
Comment 7 Wenson Hsieh 2018-10-07 19:56:16 PDT 
Created attachment 351758 [details]
Patch
Comment 8 Tim Horton 2018-10-08 15:42:01 PDT 
Comment on attachment 351758 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351758&action=review

> Source/WebCore/PAL/pal/spi/cocoa/NSAttributedStringSPI.h:110
> +#if PLATFORM(IOS) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED < 101300)

Are these exported? Should they be like all the other constants above (other than NSSuperscript)?
Comment 9 Wenson Hsieh 2018-10-08 15:56:04 PDT 
Comment on attachment 351758 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351758&action=review

>> Source/WebCore/PAL/pal/spi/cocoa/NSAttributedStringSPI.h:110
>> +#if PLATFORM(IOS) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED < 101300)
> 
> Are these exported? Should they be like all the other constants above (other than NSSuperscript)?

AFAICT, these are neither exported on iOS, nor on macOS prior to the High Sierra SDK :(
Comment 10 Wenson Hsieh 2018-10-08 18:30:25 PDT 
Created attachment 351843 [details]
Rebase on trunk
Comment 11 WebKit Commit Bot 2018-10-08 18:52:57 PDT 
Comment on attachment 351843 [details]
Rebase on trunk

Clearing flags on attachment: 351843

Committed r236955: <https://trac.webkit.org/changeset/236955>
Comment 12 WebKit Commit Bot 2018-10-08 18:52:59 PDT 
All reviewed patches have been landed.  Closing bug.