Bug 190333 - [Payment Request] Requests should be aborted after details settle when the user cancels
Summary: [Payment Request] Requests should be aborted after details settle when the us...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-06 17:22 PDT by Andy Estes
Modified: 2018-10-08 10:23 PDT (History)
8 users (show)

See Also:

Attachments
Patch (8.33 KB, patch)
2018-10-06 17:40 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (8.37 KB, patch)
2018-10-06 17:55 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2018-10-06 17:22:24 PDT 
[Payment Request] Requests should be aborted after details settle when the user cancels
Comment 1 Andy Estes 2018-10-06 17:40:39 PDT Comment hidden (obsolete)
Comment 2 Andy Estes 2018-10-06 17:55:37 PDT 
Created attachment 351736 [details]
Patch
Comment 3 Alex Christensen 2018-10-08 09:33:38 PDT 
Comment on attachment 351736 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351736&action=review

> Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp:668
>  void PaymentRequest::whenDetailsSettled(std::function<void()>&& callback)

Please use WTF::Function or WTF::CompletionHandler
Comment 4 Andy Estes 2018-10-08 09:51:07 PDT 
(In reply to Alex Christensen from comment #3)
> Comment on attachment 351736 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=351736&action=review
> 
> > Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp:668
> >  void PaymentRequest::whenDetailsSettled(std::function<void()>&& callback)
> 
> Please use WTF::Function or WTF::CompletionHandler

Unable, unfortunately, because JSNativeStdFunction is a std::function.
Comment 5 WebKit Commit Bot 2018-10-08 10:22:29 PDT 
Comment on attachment 351736 [details]
Patch

Clearing flags on attachment: 351736

Committed r236922: <https://trac.webkit.org/changeset/236922>
Comment 6 WebKit Commit Bot 2018-10-08 10:22:30 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-10-08 10:23:32 PDT 
<rdar://problem/45092116>